Skip to content

Remove NFS client header dependencies from LOCALIO

Chuck Lever linux-nfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 2 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

- Including <linux/nfs4.h> is also no longer needed (Neil Brown)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5NFSD: Move the RPC program definition for LOCALIOinclude/linux/nfs.h include/linux/nfslocalio.h+8 -70 replies
2/5nfs_common: Remove "#include <linux/nfs.h>" from linux/nfslocalio.hinclude/linux/nfslocalio.h+2 -10 replies
3/5NFSD: Tighten header includes in localio.cfs/nfsd/localio.c+3 -40 replies
4/5NFSD: Name the fh_maxsize value that carries no NFS versionfs/nfsd/lockd.c fs/nfsd/nfsfh.c fs/nfsd/nfsfh.h+17 -20 replies
5/5NFSD: Don't apply NFS version-specific behavior to LOCALIO requestsfs/nfsd/localio.c+2 -31 reply

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchNeilBrownMike Snitzer
SeriesR-b
1/5
2/5
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Remove NFS client header dependencies from LOCALIO

Clean up: fs/nfsd/localio.c is a server-side component, so it should avoid dependency on client-specific headers and XDR utilities.

No change in behavior is expected.

---
Changes in v2:
- Including <linux/nfs4.h> is also no longer needed (Neil Brown)

Chuck Lever (5):
NFSD: Move the RPC program definition for LOCALIO
nfs_common: Remove "#include <linux/nfs.h>" from linux/nfslocalio.h
NFSD: Tighten header includes in localio.c
NFSD: Name the fh_maxsize value that carries no NFS version
NFSD: Don't apply NFS version-specific behavior to LOCALIO requests

 fs/nfsd/localio.c          | 10 ++++------
 fs/nfsd/lockd.c            |  3 +--
 fs/nfsd/nfsfh.c            |  2 ++
 fs/nfsd/nfsfh.h            | 14 ++++++++++++++
 include/linux/nfs.h        |  7 -------
 include/linux/nfslocalio.h | 11 ++++++++++-
 6 files changed, 31 insertions(+), 16 deletions(-)
Signature · 1 line
2.54.0