Skip to content

drm/nouveau/clk: fix RAM error handling and pstate desync in nvkm_pstate_prog

Francesco Magazzu dri-devel lkml nouveau 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm/nouveau/clk: don't ignore RAM clock programming errors in nvkm_pstate_prognvkm/subdev/clk/base.c+2 -00 replies
2/2drm/nouveau/clk: only update clk->pstate after hardware programming succeedsnvkm/subdev/clk/base.c+5 -20 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLyude Paul
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] drm/nouveau/clk: fix RAM error handling and pstate desync in nvkm_pstate_prog

Follow-up to "[PATCH v2 0/4] drm/nouveau: fix list cursor use after loop in the clk pstate paths" ([email protected]). Sashiko AI review flagged three pre-existing issues while reviewing patch 2/4 of that series; the third (clk->func->prog()'s error being clobbered by nvkm_volt_set_id() in nvkm_cstate_prog()) is already fixed by patch 4/4 of that series. These two patches address the other two:

1. nvkm_pstate_prog() drops the RAM reclock error and falls through to core clock programming anyway.
2. nvkm_pstate_prog() commits clk->pstate to the new state before the hardware transition has actually succeeded.

Francesco Magazzu (2):
drm/nouveau/clk: don't ignore RAM clock programming errors in
nvkm_pstate_prog
drm/nouveau/clk: only update clk->pstate after hardware programming
succeeds

 nvkm/subdev/clk/base.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
Signature · 1 line
2.55.0