Skip to content

platform/x86: oxpec: Report tablet mode on OneXPlayer detachables

Alexander Egorov lkml platform-driver-x86 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesIn review
  2. v11 patch 1 replySuperseded

Changes in v2 from the cover letter

- add the requested Assisted-by trailer;
- split Super X from the shared G1 AMD board ID in a preceding patch;
- support the X1 and X1 Mini family using their folio keyboard ID;
- use driver globals and board switches instead of platform data and DMI;
- keep only the USB scan and notifier callbacks, with matching and reporting inlined;
- use generic keyboard vendor names and place the IDs beside their users;
- document the complete EC map comparison.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86: oxpec: Distinguish OneXPlayer Super X boarddrivers/platform/x86/oxpec.c+12 -11 reply
2/2platform/x86: oxpec: Report tablet mode on OneXPlayer detachablesdrivers/platform/x86/Kconfig drivers/platform/x86/oxpec.c+105 -03 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAntheas Kapenekakis
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] platform/x86: oxpec: Report tablet mode on OneXPlayer detachables

The OneXPlayer X1 family and Super X do not expose a firmware tablet-mode switch. Add one based on their detachable pogo-pin keyboard devices.

I checked the EC alternative suggested in review. The Super X ACPI EC operation region covers the complete 0x00-0xff register map. I captured 30 maps with the keyboard attached, 30 detached, and 30 reattached. There were no stable attached-detached-reattached changes. The named ACPI fields KBFG and SYSK did not change either. USB hotplug is therefore the only attachment state exposed by this Super X firmware.

The X1 keyboard ID was taken from public hardware information. X1, X1 Pro, and X1 Mini systems show the HAILUCK 258a:001e folio keyboard:

https://wiki.archlinux.org/title/OnexPlayer_X1_A
https://linux-hardware.org/?probe=517a6d5085
https://linux-hardware.org/?probe=98267565ff
https://linux-hardware.org/?probe=21f49ac935

The X1 family is included, but has not been tested by me because I only have the Super X. G1 is deliberately deferred because of its different keyboard layout.

Ilpo, comments on whether oxpec is the right home for this functionality are welcome.

Changes in v2:
- add the requested Assisted-by trailer;
- split Super X from the shared G1 AMD board ID in a preceding patch;
- support the X1 and X1 Mini family using their folio keyboard ID;
- use driver globals and board switches instead of platform data and DMI;
- keep only the USB scan and notifier callbacks, with matching and reporting inlined;
- use generic keyboard vendor names and place the IDs beside their users;
- document the complete EC map comparison.

Alexander Egorov (2):
platform/x86: oxpec: Distinguish OneXPlayer Super X board platform/x86: oxpec: Report tablet mode on OneXPlayer detachables

 drivers/platform/x86/Kconfig |   2 +
 drivers/platform/x86/oxpec.c | 116 ++++++++++++++++++++++++++++++++++-
 2 files changed, 117 insertions(+), 1 deletion(-)
Signature · 1 line
2.55.0