Skip to content

migration: Hardening fixes for 11.2

Peter Xu qemu-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 5 repliesIn review
  2. v15 patches 14 repliesSuperseded

Changes in v2 from the cover letter

- Added R-bs
- Patch 2/3, update commit message on wrong use of term "release buillds"
- Patch 4, fix bug Dan pointed out, use assert() for !coroutine, update commit log

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5migration: Fix possible overflow in vmstate_handle_alloc()migration/vmstate.c+77 -140 replies
2/5migration/multifd: Validate next_packet_size in zlib/zstd recvmigration/multifd-zlib.c migration/multifd-zstd.c+20 -20 replies
3/5migration/multifd: Replace assert() with error_setg() in recv pathsmigration/multifd-qatzip.c migration/multifd-qpl.c migration/multifd-uadk.c+44 -90 replies
4/5migration: Fix rare hang of migration_channel_read_peek()migration/channel.c+9 -24 replies
5/5migration/ram: Check for RAMBlock size mismatch when parsingmigration/ram.c+9 -20 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchFabiano Rosas
1/5R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] migration: Hardening fixes for 11.2

v2:
- Added R-bs
- Patch 2/3, update commit message on wrong use of term "release buillds"
- Patch 4, fix bug Dan pointed out, use assert() for !coroutine, update commit log

This is a small batch of fixes from recent reports on migration, the plan is this is only for 11.2; we don't need to rush on any of them.

RDMA migration has its own small batch.. It'll take slightly longer so I'll send them separately.

Reviews welcomed.

Peter Xu (5):
migration: Fix possible overflow in vmstate_handle_alloc() migration/multifd: Validate next_packet_size in zlib/zstd recv migration/multifd: Replace assert() with error_setg() in recv paths
migration: Fix rare hang of migration_channel_read_peek() migration/ram: Check for RAMBlock size mismatch when parsing

 migration/channel.c        | 11 ++++-
 migration/multifd-qatzip.c |  5 ++-
 migration/multifd-qpl.c    | 24 ++++++++--
 migration/multifd-uadk.c   | 24 ++++++++--
 migration/multifd-zlib.c   | 11 ++++-
 migration/multifd-zstd.c   | 11 ++++-
 migration/ram.c            | 11 ++++-
 migration/vmstate.c        | 91 ++++++++++++++++++++++++++++++++------
 8 files changed, 159 insertions(+), 29 deletions(-)
Signature · 1 line
2.54.0