Skip to content

ASoC: Intel: catpt: Code cleanup and renames

Cezary Rojewski linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ASoC: Intel: catpt: Wrap the store firmware-context proceduresound/soc/intel/catpt/core.h sound/soc/intel/catpt/device.c sound/soc/intel/catpt/loader.c+40 -360 replies
2/8ASoC: Intel: catpt: Drop redundant else-ifsound/soc/intel/catpt/loader.c+2 -20 replies
3/8ASoC: Intel: catpt: Drop redundant signature argumentsound/soc/intel/catpt/loader.c+3 -50 replies
4/8ASoC: Intel: catpt: Rename module header structsound/soc/intel/catpt/loader.c+8 -80 replies
5/8ASoC: Intel: catpt: Rename firmware loading functionssound/soc/intel/catpt/loader.c+16 -160 replies
6/8ASoC: Intel: catpt: Streamline wording of offset variablessound/soc/intel/catpt/loader.c+22 -260 replies
7/8ASoC: Intel: catpt: Streamline runtime-variables namingsound/soc/intel/catpt/pcm.c+21 -210 replies
8/8ASoC: Intel: catpt: Streamline control-variables namingsound/soc/intel/catpt/pcm.c+1 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] ASoC: Intel: catpt: Code cleanup and renames

Direct follow up to the cleanup from June [1] and fixes from May [2]. Patches 4/8 and 5/8 is what I actually started with, several years ago when doing first attempts in addressing the long-standing problem [3]. With these, it is easy for a developer to move between the driver and the firmware repository. A clear example of why naming is imporant.

Patches 2-8 carry no functional impact.
Patch 1/8 slightly alters the suspend procedure as explained in its commit message. From practical perspective though, 1/8 too has no real impact on the functional flow.

Changes found here reduce the code complexity slightly and rename a bunch of functions and variables.

[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/linux-sound/[email protected]/
[3]: https://lore.kernel.org/linux-sound/[email protected]/

Cezary Rojewski (8):
ASoC: Intel: catpt: Wrap the store firmware-context procedure
ASoC: Intel: catpt: Drop redundant else-if
ASoC: Intel: catpt: Drop redundant signature argument
ASoC: Intel: catpt: Rename module header struct
ASoC: Intel: catpt: Rename firmware loading functions
ASoC: Intel: catpt: Streamline wording of offset variables
ASoC: Intel: catpt: Streamline runtime-variables naming
ASoC: Intel: catpt: Streamline control-variables naming

 sound/soc/intel/catpt/core.h   |   4 +-
 sound/soc/intel/catpt/device.c |  33 +--------
 sound/soc/intel/catpt/loader.c | 131 ++++++++++++++++++++-------------
 sound/soc/intel/catpt/pcm.c    |  45 ++++++-----
 4 files changed, 105 insertions(+), 108 deletions(-)
Signature · 1 line
2.34.1