Skip to content

RFC mm/damon: cleanup code, add test cases, and update guidances in docs

SJ Park damon linux-doc linux-kselftest linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12mm/damon/core: use damon_nr_samples_per_aggr() for max merge thresholdmm/damon/core.c+1 -20 replies
2/12mm/damon/core: remove debug messagesmm/damon/core.c+0 -90 replies
3/12mm/damon/vaddr: remove a debug messagemm/damon/vaddr.c+3 -130 replies
4/12mm/damon/core: validate number of probes in valid_probe_params()mm/damon/core.c+7 -00 replies
5/12mm/damon/sysfs: remove probes number validationmm/damon/sysfs.c+1 -11 reply
6/12mm/damon/tests/core-kunit: extend set_regions() test for error casemm/damon/tests/core-kunit.h+10 -80 replies
7/12mm/damon/tests/core-kunit: test <=0 size damon_set_regions() inputsmm/damon/tests/core-kunit.h+14 -00 replies
8/12mm/damon/tests/core-kunit: test overlapping ranges for set_regions()mm/damon/tests/core-kunit.h+11 -00 replies
9/12mm/damon/tests/core-kunit: test damon_nr_samples_per_aggr()mm/damon/tests/core-kunit.h+22 -00 replies
10/12selftests/damon/sysfs.sh: test hugepage_mem_bp quota goaltools/testing/selftests/damon/sysfs.sh+1 -00 replies
11/12Docs/mm/damon/maintainer-profile: update AI review for Sashiko repliesDocumentation/mm/damon/maintainer-profile.rst+5 -140 replies
12/12Docs/ABI/damon: recommend subsystem doc instead of admin-guideDocumentation/ABI/testing/sysfs-kernel-mm-damon+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH v1.2 00/12] mm/damon: cleanup code, add test cases, and update guidances in docs

Misc cleanup, improvements and updates of code, test, and documents.

Patches 1-5 cleanup DAMON code. Patches 6-10 adds kunit and selftest test cases for recently fixed bugs and a new feature. Patches 11 and 12 update guidelines for AI review and what document to read, on DAMON documents.

Changes from RFC v1.1
- RFC v1.1: https://lore.kernel.org/[email protected]
- Fix a typo: s/alingment/alignment/.
- Add damon probes parameter validation cleanup (patches 4 and 5). Changes from RFC
- RFC: https://lore.kernel.org/[email protected]
- Remove ctx parameter of __damon_va_init_regions().
- Fix damon_nr_samples_per_aggr() overflow kunit test.
- Rebase to the latest mm-new.

SJ Park (12):
mm/damon/core: use damon_nr_samples_per_aggr() for max merge threshold mm/damon/core: remove debug messages
mm/damon/vaddr: remove a debug message
mm/damon/core: validate number of probes in valid_probe_params() mm/damon/sysfs: remove probes number validation mm/damon/tests/core-kunit: extend set_regions() test for error case mm/damon/tests/core-kunit: test <=0 size damon_set_regions() inputs mm/damon/tests/core-kunit: test overlapping ranges for set_regions() mm/damon/tests/core-kunit: test damon_nr_samples_per_aggr() selftests/damon/sysfs.sh: test hugepage_mem_bp quota goal Docs/mm/damon/maintainer-profile: update AI review for Sashiko replies Docs/ABI/damon: recommend subsystem doc instead of admin-guide

 .../ABI/testing/sysfs-kernel-mm-damon         |  2 +-
 Documentation/mm/damon/maintainer-profile.rst | 19 ++----
 mm/damon/core.c                               | 19 +++---
 mm/damon/sysfs.c                              |  2 +-
 mm/damon/tests/core-kunit.h                   | 65 ++++++++++++++++---
 mm/damon/vaddr.c                              | 16 +----
 tools/testing/selftests/damon/sysfs.sh        |  1 +
 7 files changed, 76 insertions(+), 48 deletions(-)

base-commit: a8aa6f3b608c8c9119a7978f5f4eb083c53ea56b

Signature · 1 line
2.47.3