Skip to content

vsock/virtio: fix worker access after virtqueue teardown

Weiming Shi kvm lkml netdev virtualization 2 versions Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesApplied 2/2
  2. v22 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- Resend the series with proper email threading; no code changes.

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2vsock/virtio: read virtqueues under worker locksnet/vmw_vsock/virtio_transport.c+6 -51 replyApplied
2/2vsock/virtio: avoid refilling the RX queue after teardownnet/vmw_vsock/virtio_transport.c+2 -11 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBobby EshlemanStefano Garzarella
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] vsock/virtio: fix worker access after virtqueue teardown

Virtio-vsock workers can remain queued while freeze deletes the virtqueues. This series prevents workers delayed across freeze and restore from retaining pointers to deleted queues, and prevents the RX worker from refilling its queue after teardown.

Changes in v3:
- Resend the series with proper email threading; no code changes.

Changes in v2:
- Split the worker pointer changes from the RX refill fix because they fix different commits.
- Use bd50c5dc182b as the Fixes tag for the worker pointer changes.
- Keep b917507e5ad9 as the Fixes tag for the RX refill fix.
- Use the suggested out_nofill label when rx_run is clear.

Weiming Shi (2):
vsock/virtio: read virtqueues under worker locks vsock/virtio: avoid refilling the RX queue after teardown

 net/vmw_vsock/virtio_transport.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

base-commit: 51b093a7ba27476e1f639455f005e8d2e75390e4

Signature · 1 line
2.55.0