Skip to content

watchdog: Fix two kernel-doc parameter warnings

Babanpreet Singh linux-watchdog linuxppc-dev lkml 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2watchdog: wdrtas: Fix kernel-doc parameter name for wdrtas_reboot()drivers/watchdog/wdrtas.c+1 -11 reply
2/2watchdog: booke_wdt: Document unused parameter of __booke_wdt_disable()drivers/watchdog/booke_wdt.c+1 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] watchdog: Fix two kernel-doc parameter warnings

Two independent kernel-doc parameter fixes in drivers/watchdog, found by scripts/kernel-doc -none. Both warnings are in .c files, so they appear in a W=1 build, and both files are clean afterwards.

Patch 1 fixes a name mismatch: wdrtas_reboot() names its notifier block argument 'this' while the doc block says '@nb'. Patch 2 adds the missing description for the argument __booke_wdt_disable() receives from on_each_cpu() and ignores.

They touch different drivers and are not a logical unit, so they are split rather than squashed; either can be dropped without affecting the other.

One thing I would rather state than have assumed: both drivers are PowerPC-only and I have no PowerPC toolchain here, so neither file was compiled. The whole series is three lines and every one of them is inside a /** */ block, so there is no code change to compile. Checked with scripts/kernel-doc -none (3 warnings across these two files before, 0 after) and checkpatch --strict.

Babanpreet Singh (2):
watchdog: wdrtas: Fix kernel-doc parameter name for wdrtas_reboot()
watchdog: booke_wdt: Document unused parameter of

    __booke_wdt_disable()
 drivers/watchdog/booke_wdt.c | 1 +
 drivers/watchdog/wdrtas.c    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.43.0