Skip to content

ASoC: SOF: Intel: Handle ACE2+ link DMA allocation restrictions

Peter Ujfalusi linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: SOF: Intel: hda: Fold mlink enumeration into hda_dsp_ctrl_init_chip()sound/soc/sof/intel/hda-ctrl.c sound/soc/sof/intel/hda-mlink.c sound/soc/sof/intel/hda.c+12 -20 replies
2/4ASoC: SOF: Intel: hda: Keep non-alt mlinks powered at probe on ACE2+sound/soc/sof/intel/hda.c+0 -20 replies
3/4ASoC: SOF: Intel: hda: Remove unused hda_bus_ml_put_all()include/sound/hda-mlink.h sound/soc/sof/intel/hda-mlink.c+0 -150 replies
4/4ASoC: SOF: Intel: hda: Avoid ACE2+ link DMA stream allocation hazardsinclude/sound/hda-mlink.h sound/soc/sof/intel/hda-ctrl.c sound/soc/sof/intel/hda-dai-ops.c +3 more+146 -80 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchKai VehmanenBard LiaoLiam Girdwood
1/4R-b R-b R-b
2/4R-b R-b R-b
3/4R-b R-b R-b
4/4R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] ASoC: SOF: Intel: Handle ACE2+ link DMA allocation restrictions

Hi,

We have seen cases when the delay reporting unexpectedly behaves incorrectly, counters are not counting in hardware registers under seemingly random conditions.
It turned out that there are few cases that the driver must handle in order to make sure that LLP, PPLC counters are working correctly:

- non-alt links must not be reset during probe
- Concurrent (cross-direction) hazard: when SoundWire shares a physical link DMA stream index with HDaudio, iDisp or UAOL across the two directions, the LLP and timestamp values for the affected stream are wrong. SSP and DMIC are not affected because every DMA request from those links carries one sample block.

- Sequential (playback only) hazard: once a HDaudio or iDisp link has used a playback stream index, that index cannot drive any non HDA/iDisp link in the same direction until the next controller reset (CRST#).

For users the impact was not visible as the link counter issue only affected the delay reporting which already have defensive path to filter out incorrect delays and the DSP caused delay for normal PCMs are negligible to cause A/V sync issues for example.

Regards,
Peter
--
Peter Ujfalusi (4):
ASoC: SOF: Intel: hda: Fold mlink enumeration into
hda_dsp_ctrl_init_chip()
ASoC: SOF: Intel: hda: Keep non-alt mlinks powered at probe on ACE2+
ASoC: SOF: Intel: hda: Remove unused hda_bus_ml_put_all()
ASoC: SOF: Intel: hda: Avoid ACE2+ link DMA stream allocation hazards

 include/sound/hda-mlink.h         | 23 +++++++++-
 sound/soc/sof/intel/hda-ctrl.c    | 19 ++++++++
 sound/soc/sof/intel/hda-dai-ops.c | 76 ++++++++++++++++++++++++++++---
 sound/soc/sof/intel/hda-dai.c     |  2 +-
 sound/soc/sof/intel/hda-mlink.c   | 35 ++++++++------
 sound/soc/sof/intel/hda.c         |  4 --
 sound/soc/sof/intel/hda.h         | 26 ++++++++++-
 7 files changed, 158 insertions(+), 27 deletions(-)
Signature · 1 line
2.55.0