Skip to content

wifi: brcm80211: performance and stability fixes

Shivesh brcm80211 linux-wireless lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest8 patches 3 repliesIn review
  2. v38 patches 0 repliesSuperseded
  3. v28 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches0 repliesSuperseded

Changes in v4 from the cover letter

- cfg80211.c: Removed spurious double blank line flagged by checkpatch --strict.
- All commit messages rewritten to follow kernel standards:
explain the problem symptom first, then the solution, add
Fixes: tags where applicable, wrap lines at 72 chars.
- pcie.c: Added Fixes: tag referencing the original PCIe commit.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8wifi: brcmfmac: flowring: replace O(N) blocked-ring scan with atomic counterdrivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/flowring.h+66 -170 replies
2/8wifi: brcmfmac: sdio: coalesce sdio_claim_host calls in rxglom pathdrivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c+38 -240 replies
3/8wifi: brcmfmac: core: fix missing headroom check and populate radiotap RSSIdrivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c+29 -150 replies
4/8wifi: brcmfmac: cfg80211: implement PMKID_V2 and fix brcmf_delay busy-waitdrivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h+115 -121 reply
5/8wifi: brcmfmac: msgbuf: fix TX stall and tune buffer/threshold constantsdrivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c+61 -80 replies
6/8wifi: brcmfmac: pcie: replace msleep polling with usleep_range and backoffdrivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c+58 -80 replies
7/8wifi: brcmfmac: fwsignal: document safe no-op for duplicate MAC handle ADDdrivers/net/wireless/broadcom/brcm80211/brcmfmac/fwsignal.c+3 -10 replies
8/8wifi: brcmsmac: ampdu: document IEEE 802.11n TID requirementdrivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c+5 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/8] wifi: brcm80211: performance and stability fixes

This series fixes several performance bottlenecks and correctness issues in both brcmfmac (PCIe/SDIO) and brcmsmac drivers.

Changes since v3:
- cfg80211.c: Removed spurious double blank line flagged by checkpatch --strict.
- All commit messages rewritten to follow kernel standards:
explain the problem symptom first, then the solution, add
Fixes: tags where applicable, wrap lines at 72 chars.
- pcie.c: Added Fixes: tag referencing the original PCIe commit.

Changes since v2:
- core.c: Add skb_cow_head() before skb_push() to prevent a kernel panic when skb arrives with zero headroom.
- cfg80211.c: Fix PMKID V2 shadow counter corruption bug.

Changes since v1:
- Correct author and Signed-off-by to [email protected].

Patch overview:
1/8 flowring: Replace O(N) blocked-ring scan with atomic counter. 2/8 sdio: Coalesce N+1 sdio_claim_host() pairs in rxglom path. 3/8 core: Fix skb_push() panic; populate radiotap RSSI field. 4/8 cfg80211: Implement PMKID_V2; fix shadow counter overwrite;
replace mdelay() with usleep_range().
5/8 msgbuf: Fix silent TX stall; increase NR_TX_PKTIDS to 4096. 6/8 pcie: Replace msleep() with usleep_range() + backoff. 7/8 fwsignal: Document safe no-op for duplicate MAC handle ADD. 8/8 brcmsmac/ampdu: Reference IEEE 802.11n TID requirement.

Shivesh (8):
wifi: brcmfmac: flowring: replace O(N) blocked-ring scan with atomic
counter
wifi: brcmfmac: sdio: coalesce sdio_claim_host calls in rxglom path
wifi: brcmfmac: core: fix missing headroom check and populate radiotap
RSSI
wifi: brcmfmac: cfg80211: implement PMKID_V2 and fix brcmf_delay
busy-wait
wifi: brcmfmac: msgbuf: fix TX stall and tune buffer/threshold
constants
wifi: brcmfmac: pcie: replace msleep polling with usleep_range and
backoff
wifi: brcmfmac: fwsignal: document safe no-op for duplicate MAC handle
ADD
wifi: brcmsmac: ampdu: document IEEE 802.11n TID requirement

 .../broadcom/brcm80211/brcmfmac/cfg80211.c    | 122 ++++++++++++++++--
 .../broadcom/brcm80211/brcmfmac/cfg80211.h    |   4 +-
 .../broadcom/brcm80211/brcmfmac/core.c        |  44 ++++---
 .../broadcom/brcm80211/brcmfmac/flowring.c    |  65 +++++++---
 .../broadcom/brcm80211/brcmfmac/flowring.h    |  18 +++
 .../broadcom/brcm80211/brcmfmac/fwsignal.c    |   4 +-
 .../broadcom/brcm80211/brcmfmac/msgbuf.c      |  69 ++++++++--
 .../broadcom/brcm80211/brcmfmac/pcie.c        |  66 ++++++++--
 .../broadcom/brcm80211/brcmfmac/sdio.c        |  62 +++++----
 .../broadcom/brcm80211/brcmsmac/ampdu.c       |  11 +-
 10 files changed, 374 insertions(+), 91 deletions(-)

base-commit: 5e0bcb4920bcb9e0ef6c03a91730fe45f643f3a4

Signature · 1 line
2.53.0