Skip to content

staging: rtl8723bs: clean up management transmit return values

Hungyu Lin linux-staging lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Clarify commit messages based on review feedback.
- Make dump_mgntframe_and_wait() return void instead of converting it to errno values.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: rtl8723bs: convert mgmt xmit coalesce to errnodrivers/staging/rtl8723bs/core/rtw_xmit.c drivers/staging/rtl8723bs/include/rtw_xmit.h+5 -50 replies
2/3staging: rtl8723bs: propagate errno handling for mgmt xmitdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/include/hal_intf.h+12 -30 replies
3/3staging: rtl8723bs: make dump_mgntframe_and_wait() return voiddrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/include/rtw_mlme_ext.h+5 -140 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDan Carpenter
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] staging: rtl8723bs: clean up management transmit return values

This series continues the cleanup of management transmit return values in the rtl8723bs driver.

Patch 1 converts rtw_mgmt_xmitframe_coalesce() to return kernel-style errno values.

Patch 2 propagates the new return value convention through rtw_hal_mgnt_xmit().

Patch 3 makes dump_mgntframe_and_wait() return void, since none of its current callers use its return value. It still uses the return value from rtw_hal_mgnt_xmit() internally to determine whether to wait for completion.

Changes in v2:
- Clarify commit messages based on review feedback.
- Make dump_mgntframe_and_wait() return void instead of converting it to errno values.

Hungyu Lin (3):
staging: rtl8723bs: convert mgmt xmit coalesce to errno
staging: rtl8723bs: propagate errno handling for mgmt xmit
staging: rtl8723bs: make dump_mgntframe_and_wait() return void

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c    | 13 ++++---------
 drivers/staging/rtl8723bs/core/rtw_xmit.c        |  8 ++++----
 drivers/staging/rtl8723bs/hal/hal_intf.c         |  9 +++++++--
 drivers/staging/rtl8723bs/include/hal_intf.h     |  2 +-
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h |  2 +-
 drivers/staging/rtl8723bs/include/rtw_xmit.h     |  2 +-
 6 files changed, 18 insertions(+), 18 deletions(-)
Signature · 1 line
2.43.0