Skip to content

dpll: use pin owner's dpll ref for pin-level set callbacks

Ivan Vecera linux-doc lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesApplied 2/2
  2. v22 patches 3 repliesSuperseded
  3. v11 patch 1 replySuperseded

Changes in v3 from the cover letter

- Fix missing mutex_unlock on the normal loop path (was only on the early-continue branch) - folded into patch 1
- Skip channels where sync ref priority is already NONE
- Send __dpll_pin_change_ntf for the sync pin when priority changed
- Reword dpll.rst to describe observable effect, restore rationale
- Align changelog: "recommended" instead of "must"
- Use 7-bit ASCII throughout
- Rebase onto current origin/main

Patches in v3 All 2 applied

#Subject and filesSizeRepliesApplied
1/2dpll: zl3073x: update all DPLL channels on ref_sync_setdrivers/dpll/zl3073x/dpll.c+48 -102 repliesApplied
2/2dpll: use pin owner's dpll ref for pin-level attribute settingDocumentation/driver-api/dpll.rst drivers/dpll/dpll_netlink.c+56 -1681 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoPetr Oros
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] dpll: use pin owner's dpll ref for pin-level set callbacks

Pin-level attributes (frequency, phase adjust, embedded sync, reference sync) are properties of the pin itself. The get callbacks already use only the pin owner's DPLL reference, but the set callbacks iterate over all registered DPLL devices, resulting in redundant HW writes for drivers that share a pin across multiple DPLLs.

This series simplifies the set side to match the get side: call the set callback only through the owner's reference.

Patch 1 prepares the zl3073x driver whose ref_sync_set callback had per-channel behavior (setting priority on a single DPLL channel). It now iterates all channels internally so it remains correct when invoked only once.

Patch 2 drops the xa_for_each loops from dpll_pin_freq_set(), dpll_pin_esync_set(), dpll_pin_ref_sync_state_set() and dpll_pin_phase_adj_set(), along with the rollback logic and the per-ref -EOPNOTSUPP validation scan. The dpll.rst documentation is updated to reflect the new behavior.

v3:
- Fix missing mutex_unlock on the normal loop path (was only on the early-continue branch) - folded into patch 1
- Skip channels where sync ref priority is already NONE
- Send __dpll_pin_change_ntf for the sync pin when priority changed
- Reword dpll.rst to describe observable effect, restore rationale
- Align changelog: "recommended" instead of "must"
- Use 7-bit ASCII throughout
- Rebase onto current origin/main
v2:
- Split zl3073x ref_sync_set fix into a separate preparation patch
- Update dpll.rst documentation to match the new behavior
- Expand commit message to describe the -EOPNOTSUPP check change

Ivan Vecera (2):
dpll: zl3073x: update all DPLL channels on ref_sync_set
dpll: use pin owner's dpll ref for pin-level attribute setting

 Documentation/driver-api/dpll.rst |  11 +-
 drivers/dpll/dpll_netlink.c       | 213 +++++++-----------------------
 drivers/dpll/zl3073x/dpll.c       |  58 ++++++--
 3 files changed, 104 insertions(+), 178 deletions(-)

base-commit: 4fa4977a0d900f936bcae5cd2c510be5554e8dd6

Signature · 1 line
2.54.0