iio: adc: bcm_iproc_adc: Simplify probe error handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest3 patches 4 repliesIn review
- v53 patches 2 repliesSuperseded
- v43 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 5 replies | Superseded |
Changes in v6 from the cover letter
- Restore the original formatting in Patch 2 to avoid unnecessary code churn, as suggested by Jonathan.
- Reduce indentation in selected dev_err_probe() calls in Patch 3 following review comments from Markus.
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | iio: adc: bcm_iproc_adc: Remove redundant probe error messagesdrivers/ | +2 | 1 reply | |
| 2/3 | iio: adc: bcm_iproc_adc: Introduce local device pointerdrivers/ | +4 | 1 reply | |
| 3/3 | iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe()drivers/ | +10 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling
From: Mohammad Shahid <[email protected]>
This series simplifies probe error handling in bcm_iproc_adc.
Patch 1 removes redundant probe error messages where lower-level helpers already report failures.
Patch 2 introduces a local device pointer to reduce repetition and prepare for subsequent error handling cleanup.
Patch 3 converts immediate-return probe error paths to dev_err_probe() while leaving cleanup paths unchanged.
Changes in v6:
- Restore the original formatting in Patch 2 to avoid unnecessary code churn, as suggested by Jonathan.
- Reduce indentation in selected dev_err_probe() calls in Patch 3 following review comments from Markus.
---
Mohammad Shahid (3):
iio: adc: bcm_iproc_adc: Remove redundant probe error messages
iio: adc: bcm_iproc_adc: Introduce local device pointer
iio: adc: bcm_iproc_adc: Convert probe error handling to
dev_err_probe()
drivers/iio/adc/bcm_iproc_adc.c | 46 ++++++++++++--------------------- 1 file changed, 16 insertions(+), 30 deletions(-)
Signature · 1 line
2.43.0