Skip to content

iio: adc: bcm_iproc_adc: Simplify probe error handling

[email protected] linux-arm-kernel linux-iio lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 4 repliesIn review
  2. v53 patches 2 repliesSuperseded
  3. v43 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v33 patches5 repliesSuperseded

Changes in v6 from the cover letter

- Restore the original formatting in Patch 2 to avoid unnecessary code churn, as suggested by Jonathan.
- Reduce indentation in selected dev_err_probe() calls in Patch 3 following review comments from Markus.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3iio: adc: bcm_iproc_adc: Remove redundant probe error messagesdrivers/iio/adc/bcm_iproc_adc.c+2 -61 reply
2/3iio: adc: bcm_iproc_adc: Introduce local device pointerdrivers/iio/adc/bcm_iproc_adc.c+4 -41 reply
3/3iio: adc: bcm_iproc_adc: Convert probe error handling to dev_err_probe()drivers/iio/adc/bcm_iproc_adc.c+10 -202 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] iio: adc: bcm_iproc_adc: Simplify probe error handling

From: Mohammad Shahid <[email protected]>

This series simplifies probe error handling in bcm_iproc_adc.

Patch 1 removes redundant probe error messages where lower-level helpers already report failures.

Patch 2 introduces a local device pointer to reduce repetition and prepare for subsequent error handling cleanup.

Patch 3 converts immediate-return probe error paths to dev_err_probe() while leaving cleanup paths unchanged.

Changes in v6:
- Restore the original formatting in Patch 2 to avoid unnecessary code churn, as suggested by Jonathan.
- Reduce indentation in selected dev_err_probe() calls in Patch 3 following review comments from Markus.

---

Mohammad Shahid (3):
iio: adc: bcm_iproc_adc: Remove redundant probe error messages
iio: adc: bcm_iproc_adc: Introduce local device pointer
iio: adc: bcm_iproc_adc: Convert probe error handling to

    dev_err_probe()
 drivers/iio/adc/bcm_iproc_adc.c | 46 ++++++++++++---------------------
 1 file changed, 16 insertions(+), 30 deletions(-)
Signature · 1 line
2.43.0