Skip to content

t7528: fix failure under csh

Kenneth Lorber git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1t7528: fix failure under csht/t7528-signed-commit-ssh.sh+1 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] t7528: fix failure under csh

The test suite fails at t7528 when run in an account with tcsh as the login shell due to $SHELL being "/bin/tcsh"; similar behaviour is expected under other csh-like shells.

From ssh-agent(1):
-s Generate Bourne shell commands on stdout. This is the default
if SHELL does not look like it's a csh style of shell.

This patch explicitly tells ssh-agent to use Bourne shell syntax, thus removing a spurious test failure for users with csh style shells.

An alternative change would be to have test-lib.sh clear $SHELL; this was rejected as potentially hiding additional similar errors. There are no such additional errors evident currently.

No additional tests are added as the error is in the setup for testing, not an error in git itself.

Kenneth Lorber (1):
t7528: fix failure under csh

 t/t7528-signed-commit-ssh.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.43.0