Skip to content

x86: Use "er" asm constriant for add/sub

David Laight linux-iio lkml 1 version Applied

Status from this message: The following commit has been merged into the x86/urgent branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 19 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2lib: mul_u64_add_u64_div_u64: Fix addition of large constantsarch/x86/include/asm/div64.h+1 -11 reply
2/2x86/local: local_add/local_sub: Support large immediate valuesarch/x86/include/asm/local.h+2 -22 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPeter Zijlstra (Intel)H. Peter Anvin
1/2R-b
2/2A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] x86: Use "er" asm constriant for add/sub

The x86 instruction set only supports 32bit signed immediate values for add/sub.
Replace the "ir" constraint with "er" to avoid build errors.

Found by a patch that added used mul_u64_add_u64_div_u64() to do a rounding divide by 2^32 (perhaps not the best way to do this).

A quick grep only found one other affected file.

David Laight (2):
lib: mul_u64_add_u64_div_u64: Fix addition of large constants x86/local: local_add/local_sub: Support large immediate values

 arch/x86/include/asm/div64.h | 2 +-
 arch/x86/include/asm/local.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.39.5