devtool: upgrade: improve changelog extraction for git-log-style ChangeLogs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 0 repliesNew
- v23 patches 3 repliesSuperseded
- v12 patches 2 repliesSuperseded
Changes in v3 from the cover letter
- drop already merged patch.
- as suggested in the review use subprocess.run() and drop helper function
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | devtool: upgrade: call subprocess.run() instead of bb.process.run()scripts/ | +6 | 0 replies | |
| 2/2 | devtool: upgrade: diff git-log-style changelogs by commit hashscripts/ | +52 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/2] devtool: upgrade: improve changelog extraction for git-log-style ChangeLogs
From: Daniel Turull <[email protected]>
devtool upgrade's changelog extraction misattributed unrelated commits when upgrading recipes like nghttp2, whose ChangeLog is the literal output of git log, regenerated wholesale on every release.
Changes from v1:
- Header-skipping in the structural diff now relies on the blank line git log always inserts before the commit message, instead of enumerating header prefixes with a regex.
- The UTF-8 decode fix is split into its own patch and applied to both git-show call sites instead of just one.
- A single-use helper that only sequenced two operations with no reuse benefit has been inlined into its caller.
- The git-diff fallback is now guarded against UnicodeDecodeError too, so a bad byte in the diff hunk itself doesn't crash extraction.
Changes from v2:
- drop already merged patch.
- as suggested in the review use subprocess.run() and drop helper function
Daniel Turull (2):
devtool: upgrade: call subprocess.run() instead of bb.process.run()
devtool: upgrade: diff git-log-style changelogs by commit hash
scripts/lib/devtool/upgrade.py | 68 +++++++++++++++++++++++++++++----- 1 file changed, 58 insertions(+), 10 deletions(-)