platform/x86: hp-bioscfg: fix multiple memory safety bugs and parsing errors
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest9 patches 4 repliesIn review
- v113 patches 2 repliesSuperseded
Changes in v2 from the cover letter
- Squash patches 9-13 from v1 into a single patch (now patch 9), as the fix is identical across all five attribute-type parsers. Requested by Ilpo Järvinen.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | platform/x86: hp-bioscfg: fix off-by-one write in hp_get_string_from_bufferdrivers/ | +1 | 0 replies | |
| 2/9 | platform/x86: hp-bioscfg: fix heap OOB read in sk_store and kek_storedrivers/ | +2 | 0 replies | |
| 3/9 | platform/x86: hp-bioscfg: fix heap OOB read on empty password writedrivers/ | +1 | 0 replies | |
| 4/9 | platform/x86: hp-bioscfg: fix 16-byte heap overflow for empty auth tokendrivers/ | +1 | 1 reply | |
| 5/9 | platform/x86: hp-bioscfg: fix off-by-one heap OOB write in audit_log_entries_showdrivers/ | +1 | 1 reply | |
| 6/9 | platform/x86: hp-bioscfg: add missing bounds check in PSWD_ENCODINGS loopdrivers/ | +5 | 0 replies | |
| 7/9 | platform/x86: hp-bioscfg: fix new_password_store overwriting current_passworddrivers/ | +1 | 0 replies | |
| 8/9 | platform/x86: hp-bioscfg: fix ORD_LIST_ELEMENTS never being parseddrivers/ | +3 | 0 replies | |
| 9/9 | platform/x86: hp-bioscfg: advance elem past consumed array elementsdrivers/ drivers/ drivers/ +2 more | +14 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/9] platform/x86: hp-bioscfg: fix multiple memory safety bugs and parsing errors
This series fixes several bugs in the hp-bioscfg driver:
1. Memory safety issues (patches 1-6):
- Off-by-one NUL terminator write in hp_get_string_from_buffer()
- Heap OOB read in sk_store()/kek_store() when passing original count instead of trimmed length to hp_wmi_perform_query()
- Heap OOB read on empty password write in validate_password_input()
- 16-byte heap overflow in hp_calculate_security_buffer() for empty authentication tokens
- Off-by-one heap OOB write in audit_log_entries_show() when more than 256 log entries are reported
- Missing bounds check in the PSWD_ENCODINGS parsing loop
2. Logic bugs (patches 7-8):
- new_password_store() incorrectly passing is_current=true, causing writes to land in current_password instead
- ORD_LIST_ELEMENTS case using a stale NULL str_value pointer instead of converting the current ACPI element directly
3. ACPI package element index tracking (patch 9):
- Five attribute-type parsers (enum, int, string, order-list, passwd) all share the same defect: multi-element array cases consume "size" consecutive elements but the outer loop only advances by one, causing the next iteration to misread a leftover array entry as the next property and abort with -EIO
Tested on HP EliteBook 840 G2 (BIOS M71 Ver. 01.31), kernel 7.2.0-rc5+, with CONFIG_KASAN_GENERIC=y and CONFIG_SLUB_DEBUG=y.
This series applies on top of:
commit ea4d8f8ba283 ("platform/x86: hp-bioscfg: fix slab-out-of-bounds write in hp_convert_hexstr_to_str")
Changes in v2:
- Squash patches 9-13 from v1 into a single patch (now patch 9), as the fix is identical across all five attribute-type parsers. Requested by Ilpo Järvinen.
v1: https://lore.kernel.org/all/[email protected]/
Muhammad Bilal (9):
platform/x86: hp-bioscfg: fix off-by-one write in
hp_get_string_from_buffer
platform/x86: hp-bioscfg: fix heap OOB read in sk_store and kek_store platform/x86: hp-bioscfg: fix heap OOB read on empty password write platform/x86: hp-bioscfg: fix 16-byte heap overflow for empty auth
token
platform/x86: hp-bioscfg: fix off-by-one heap OOB write in
audit_log_entries_show
platform/x86: hp-bioscfg: add missing bounds check in PSWD_ENCODINGS
loop
platform/x86: hp-bioscfg: fix new_password_store overwriting
current_password
platform/x86: hp-bioscfg: fix ORD_LIST_ELEMENTS never being parsed platform/x86: hp-bioscfg: advance elem past consumed array elements
drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 2 +- .../platform/x86/hp/hp-bioscfg/enum-attributes.c | 4 ++++ drivers/platform/x86/hp/hp-bioscfg/int-attributes.c | 2 ++ .../x86/hp/hp-bioscfg/order-list-attributes.c | 6 +++++- .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 13 +++++++++++-- .../platform/x86/hp/hp-bioscfg/spmobj-attributes.c | 6 +++--- .../platform/x86/hp/hp-bioscfg/string-attributes.c | 2 ++ .../x86/hp/hp-bioscfg/surestart-attributes.c | 2 +- 8 files changed, 29 insertions(+), 8 deletions(-)
Signature · 1 line
2.55.0