Skip to content

drm/i915/display: Enable AS SDP Skip Frames

Uma Shankar intel-gfx intel-xe sashiko-reviews 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 2 repliesIn review
  2. v44 patches 9 repliesSuperseded
  3. v34 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches3 repliesSuperseded

v4 from the cover letter

- Fix Sashiko review comments

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/display: Enable periodic AS SDP skip framesdrivers/gpu/drm/i915/display/intel_alpm.c drivers/gpu/drm/i915/display/intel_psr_regs.h+58 -50 replies
2/4drm/i915/display: Force disable DC3co when AS SDP skip frames is enableddrivers/gpu/drm/i915/display/intel_alpm.c drivers/gpu/drm/i915/display/intel_alpm.h drivers/gpu/drm/i915/display/intel_display_power.c+34 -01 reply
3/4drm/i915/display: Reprogram AS SDP skip frames on seamless VRR transitionsdrivers/gpu/drm/i915/display/intel_alpm.c drivers/gpu/drm/i915/display/intel_alpm.h drivers/gpu/drm/i915/display/intel_display.c+100 -380 replies
4/4drm/i915/display: Gate periodic AS SDP skip frames behind a debugfs knobdrivers/gpu/drm/i915/display/intel_alpm.c drivers/gpu/drm/i915/display/intel_display_params.h+10 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDibin Moolakadan SubrahmanianNaladala Ramanaidu
1/4R-b T-b
2/4R-b T-b
3/4R-b T-b
4/4R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [v5 0/4] drm/i915/display: Enable AS SDP Skip Frames

When Panel Replay is active the transcoder timing generator runs at the panel's maximum refresh rate, but content is often presented at a lower rate. In that case the Adaptive-Sync SDP (AS SDP) only needs to reach the panel often enough to satisfy its maximum frame time, so transmitting it on every frame is redundant and shows up as repeated SDPs on the link.

Xe3LPD adds a HW skip-frame counter in PR_ALPM_CTL that lets the source send a single AS SDP and then suppress it for a programmed number of frames. Program this counter so that one AS SDP is followed by (max_vrefresh / flip_rate - 1) idle frames, matching the effective content rate and allowing the link to be driven down to as low as 1Hz when the hardware supports it.

v5: Drop module param and add debugfs

v4:
- Fix Sashiko review comments

v3:
- Add module parameter
- Fix Skip count clearing issue (Dibin)
- Add DC3Co checks and enabling conditions

Uma Shankar (4):
drm/i915/display: Enable periodic AS SDP skip frames drm/i915/display: Force disable DC3co when AS SDP skip frames is
enabled
drm/i915/display: Reprogram AS SDP skip frames on seamless VRR
transitions
drm/i915/display: Gate periodic AS SDP skip frames behind a debugfs
knob

 drivers/gpu/drm/i915/display/intel_alpm.c     | 154 ++++++++++++++++--
 drivers/gpu/drm/i915/display/intel_alpm.h     |   3 +
 drivers/gpu/drm/i915/display/intel_display.c  |  18 ++
 .../drm/i915/display/intel_display_params.h   |   5 +
 .../drm/i915/display/intel_display_power.c    |   9 +
 drivers/gpu/drm/i915/display/intel_psr_regs.h |   2 +
 6 files changed, 175 insertions(+), 16 deletions(-)
Signature · 1 line
2.50.1