Skip to content

drm/xe: Report GT TDR and VM rebind faults using SIGID

Arvind Yadav intel-xe 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest4 patches 0 repliesNew
  2. v64 patches 9 repliesSuperseded
  3. v54 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v44 patches6 repliesSuperseded
v31 patch0 repliesSuperseded
v21 patch2 repliesSuperseded

Changes in v7 from the cover letter

- Updated the GUCSUBMIT commit message.
- Updated GuC submission wording.
- Added a GRDOM_RESET_TIMEOUT_MS constant for GT reset timeout.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/xe/log: Add GUCSUBMIT componentdrivers/gpu/drm/xe/abi/xe_log_abi.h+1 -00 replies
2/4drm/xe/guc: Report reset failure using SIGIDdrivers/gpu/drm/xe/xe_guc_submit.c+4 -20 replies
3/4drm/xe/svm: Report terminal page-fault failures using SIGIDdrivers/gpu/drm/xe/xe_svm.c+7 -60 replies
4/4drm/xe/gt: Report GT reset failure using SIGIDdrivers/gpu/drm/xe/xe_gt.c+8 -30 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMichal WajdeczkoMallesh Koujalagi
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/4] drm/xe: Report GT TDR and VM rebind faults using SIGID

This series is a small follow-up on top of the structured SIGID error logging infrastructure series:

https://patchwork.freedesktop.org/series/171022/

That series adds SIGID-based error reporting and the xe_log_*() helpers. This series converts selected GuC submission, SVM page-fault and GT reset error paths to that logging path.

The VM rebind conversion from earlier revisions remains dropped.

v7:
- Updated the GUCSUBMIT commit message.
- Updated GuC submission wording.
- Added a GRDOM_RESET_TIMEOUT_MS constant for GT reset timeout.

v6:
- Moved GUCSUBMIT from DRIVER_FIRMWARE to DRIVER, since GuC submit is a driver submission component and not a firmware component. (Michal)
- Updated the log message to print class/instance as %u:%u and reason as %#x. (Michal)

v5:
- Dropped the GuC CGP protocol SIGID conversion, since malformed G2H handler errors are already reported by the CT layer after -EPROTO.
- Added a GUCSUBMIT component mapped to XE_SIGID_GT_TDR and used it for the GuC submit reset failure.
- Dropped "request" from the GuC submit reset failure message.
- Kept the GT patch limited to the reset failure path.
- Dropped GT PM-flow SIGID conversions for now, since the correct component/SIGID mapping needs agreement.
- Improved the GT reset failure message to describe that full graphics reset did not complete.

v4:
- Clarified that the GT component maps to XE_SIGID_GT_TDR and -EIO is only the errno value.
- Split GuC CGP protocol error conversions into a separate patch.
- Added terminal SVM page-fault allocation failures as MEM_FAULT reports.
- Converted GT reset and power-flow failures to GT_TDR reports.
- Kept the VM rebind conversion dropped.

v3:
- Split GuC and VM changes into separate patches.
- Dropped GuC job-timeout warning conversions to avoid changing warning logs into error-level SIGID reports.

v2:
- Rebased on the latest structured SIGID logging series.
- Switched from the old xe_ras_log_*() helpers to the new xe_log_*() helpers.

Arvind Yadav (4):
drm/xe/log: Add GUCSUBMIT component
drm/xe/guc: Report reset failure using SIGID drm/xe/svm: Report terminal page-fault failures using SIGID drm/xe/gt: Report GT reset failure using SIGID

 drivers/gpu/drm/xe/abi/xe_log_abi.h |  1 +
 drivers/gpu/drm/xe/xe_gt.c          | 11 ++++++++---
 drivers/gpu/drm/xe/xe_guc_submit.c  |  6 ++++--
 drivers/gpu/drm/xe/xe_svm.c         | 13 +++++++------
 4 files changed, 20 insertions(+), 11 deletions(-)
Signature · 1 line
2.43.0