drm/xe: Report GT TDR and VM rebind faults using SIGID
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest4 patches 0 repliesNew
- v64 patches 9 repliesSuperseded
- v54 patches 4 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 4 patches | 6 replies | Superseded | |
| v3 | 1 patch | 0 replies | Superseded | |
| v2 | 1 patch | 2 replies | Superseded |
Changes in v7 from the cover letter
- Updated the GUCSUBMIT commit message.
- Updated GuC submission wording.
- Added a GRDOM_RESET_TIMEOUT_MS constant for GT reset timeout.
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | drm/xe/log: Add GUCSUBMIT componentdrivers/ | +1 | 0 replies | |
| 2/4 | drm/xe/guc: Report reset failure using SIGIDdrivers/ | +4 | 0 replies | |
| 3/4 | drm/xe/svm: Report terminal page-fault failures using SIGIDdrivers/ | +7 | 0 replies | |
| 4/4 | drm/xe/gt: Report GT reset failure using SIGIDdrivers/ | +8 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Michal Wajdeczko | Mallesh Koujalagi |
|---|---|---|
| 1/4 | R-b | |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v7 0/4] drm/xe: Report GT TDR and VM rebind faults using SIGID
This series is a small follow-up on top of the structured SIGID error logging infrastructure series:
https://patchwork.freedesktop.org/series/171022/
That series adds SIGID-based error reporting and the xe_log_*() helpers. This series converts selected GuC submission, SVM page-fault and GT reset error paths to that logging path.
The VM rebind conversion from earlier revisions remains dropped.
v7:
- Updated the GUCSUBMIT commit message.
- Updated GuC submission wording.
- Added a GRDOM_RESET_TIMEOUT_MS constant for GT reset timeout.
v6:
- Moved GUCSUBMIT from DRIVER_FIRMWARE to DRIVER, since GuC submit is a driver submission component and not a firmware component. (Michal)
- Updated the log message to print class/instance as %u:%u and reason as %#x. (Michal)
v5:
- Dropped the GuC CGP protocol SIGID conversion, since malformed G2H handler errors are already reported by the CT layer after -EPROTO.
- Added a GUCSUBMIT component mapped to XE_SIGID_GT_TDR and used it for the GuC submit reset failure.
- Dropped "request" from the GuC submit reset failure message.
- Kept the GT patch limited to the reset failure path.
- Dropped GT PM-flow SIGID conversions for now, since the correct component/SIGID mapping needs agreement.
- Improved the GT reset failure message to describe that full graphics reset did not complete.
v4:
- Clarified that the GT component maps to XE_SIGID_GT_TDR and -EIO is only the errno value.
- Split GuC CGP protocol error conversions into a separate patch.
- Added terminal SVM page-fault allocation failures as MEM_FAULT reports.
- Converted GT reset and power-flow failures to GT_TDR reports.
- Kept the VM rebind conversion dropped.
v3:
- Split GuC and VM changes into separate patches.
- Dropped GuC job-timeout warning conversions to avoid changing warning logs into error-level SIGID reports.
v2:
- Rebased on the latest structured SIGID logging series.
- Switched from the old xe_ras_log_*() helpers to the new xe_log_*() helpers.
Arvind Yadav (4):
drm/xe/log: Add GUCSUBMIT component
drm/xe/guc: Report reset failure using SIGID drm/xe/svm: Report terminal page-fault failures using SIGID drm/xe/gt: Report GT reset failure using SIGID
drivers/gpu/drm/xe/abi/xe_log_abi.h | 1 + drivers/gpu/drm/xe/xe_gt.c | 11 ++++++++--- drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++-- drivers/gpu/drm/xe/xe_svm.c | 13 +++++++------ 4 files changed, 20 insertions(+), 11 deletions(-)
Signature · 1 line
2.43.0