Skip to content

selftests: net: shaper: Expand shaper API coverage

Mohsin Bashir linux-kselftest lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 0 repliesApplied 14/14

Patches in v1 All 14 applied

#Subject and filesSizeRepliesApplied
1/14selftests: net: shaper: Drop redundant command timeoutstools/testing/selftests/drivers/net/shaper.py+3 -30 repliesApplied
2/14selftests: net: shaper: Prepare helpers for group teststools/testing/selftests/drivers/net/shaper.py+86 -590 repliesApplied
3/14selftests: net: shaper: Decouple basic_groups from netdev rate limitingtools/testing/selftests/drivers/net/shaper.py+16 -240 repliesApplied
4/14selftests: net: shaper: Add basic_groups_with_rate testtools/testing/selftests/drivers/net/shaper.py+68 -150 repliesApplied
5/14selftests: net: shaper: Add node scope .set rate update testtools/testing/selftests/drivers/net/shaper.py+38 -00 repliesApplied
6/14selftests: net: shaper: Add .group rate update testtools/testing/selftests/drivers/net/shaper.py+67 -00 repliesApplied
7/14selftests: net: shaper: Add nested depth limit discovery testtools/testing/selftests/drivers/net/shaper.py+117 -00 repliesApplied
8/14selftests: net: shaper: Add child node deletion reparent testtools/testing/selftests/drivers/net/shaper.py+77 -00 repliesApplied
9/14selftests: net: shaper: Add queue migration between nodes testtools/testing/selftests/drivers/net/shaper.py+102 -00 repliesApplied
10/14selftests: net: shaper: Add reparenting rejection testtools/testing/selftests/drivers/net/shaper.py+150 -00 repliesApplied
11/14selftests: net: shaper: Cover scalar attributestools/testing/selftests/drivers/net/shaper.py+68 -00 repliesApplied
12/14selftests: net: shaper: Reject invalid set requeststools/testing/selftests/drivers/net/shaper.py+41 -00 repliesApplied
13/14selftests: net: shaper: Cover mixed-parent groupingtools/testing/selftests/drivers/net/shaper.py+100 -00 repliesApplied
14/14selftests: net: shaper: Cover recursive node cleanuptools/testing/selftests/drivers/net/shaper.py+59 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/14] selftests: net: shaper: Expand shaper API coverage

From: Mohsin Bashir <[email protected]>

Add more net shaper selftest coverage for group operations and nested node management.

The series first prepares shared cleanup and capability helpers, and separates the basic netdev grouping coverage from the rate-limited variant. It then adds tests for updating node shaper rates through both .set and .group, discovering the supported nesting depth, deleting child nodes and reparenting their leaves, moving queues between nodes, and rejecting node reparenting.

Further patches broaden API coverage: exercising the full set of scalar shaper attributes, rejecting invalid .set requests while leaving the existing configuration intact, grouping leaves drawn from different parents (which requires an explicit parent), and recursively cleaning up nodes left empty.

The new tests use the capability helper to skip unsupported devices instead of depending on earlier test ordering, size their queue requirements from the number of TX queues exposed in sysfs, and register cleanup for created shapers as soon as the operation succeeds.

TAP version 13
1..22
ok 1 shaper.get_shapers
ok 2 shaper.get_caps
ok 3 shaper.set_qshapers
ok 4 shaper.del_qshapers
ok 5 shaper.set_nshapers
ok 6 shaper.del_nshapers
ok 7 shaper.set_all_supported_attrs
ok 8 shaper.invalid_set_preserves_state
ok 9 shaper.mixed_parent_group_requires_parent
ok 10 shaper.recursive_empty_node_cleanup
ok 11 shaper.basic_groups
ok 12 shaper.basic_groups_with_rate
ok 13 shaper.qgroups
ok 14 shaper.set_node_shaper
ok 15 shaper.group_update_rate
ok 16 shaper.delegation

# max nesting depth tested: 3
ok 17 shaper.nested_depth_limit
ok 18 shaper.delete_child_reparent
ok 19 shaper.move_queue_between_nodes
ok 20 shaper.reject_reparenting
ok 21 shaper.dup_leaves
ok 22 shaper.queue_update

Mohsin Bashir (14):
selftests: net: shaper: Drop redundant command timeouts
selftests: net: shaper: Prepare helpers for group tests
selftests: net: shaper: Decouple basic_groups from netdev rate
limiting
selftests: net: shaper: Add basic_groups_with_rate test
selftests: net: shaper: Add node scope .set rate update test
selftests: net: shaper: Add .group rate update test
selftests: net: shaper: Add nested depth limit discovery test
selftests: net: shaper: Add child node deletion reparent test
selftests: net: shaper: Add queue migration between nodes test
selftests: net: shaper: Add reparenting rejection test
selftests: net: shaper: Cover scalar attributes
selftests: net: shaper: Reject invalid set requests
selftests: net: shaper: Cover mixed-parent grouping
selftests: net: shaper: Cover recursive node cleanup

 tools/testing/selftests/drivers/net/shaper.py | 1065 +++++++++++++++--
 1 file changed, 978 insertions(+), 87 deletions(-)
Signature · 1 line
2.53.0-Meta