Skip to content

s390/dasd: ESE Performance improvements

Stefan Haberland linux-block linux-s390 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/19s390/dasd: Do not complete a failed ESE read as successfuldrivers/s390/block/dasd.c+4 -20 replies
2/19s390/dasd: Propagate partial completion length across ERP recoverydrivers/s390/block/dasd_erp.c+3 -00 replies
3/19s390/dasd: Guard sysfs discipline callbacks against unallocated private datadrivers/s390/block/dasd_eckd.c+38 -20 replies
4/19s390/dasd: Snapshot intrc before freeing the request blockdrivers/s390/block/dasd.c+8 -20 replies
5/19s390/dasd: Optimize max blocks per request for track alignmentdrivers/s390/block/dasd_eckd.h+1 -10 replies
6/19s390/dasd: Use GFP_KERNEL in dasd_alloc_device()drivers/s390/block/dasd.c+4 -40 replies
7/19s390/dasd: Add defines for the Extended Address Volume track addressdrivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_eckd.h+10 -20 replies
8/19s390/dasd: Add infrastructure for ESE full-track writedrivers/s390/block/dasd.c drivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_eckd.h +1 more+120 -150 replies
9/19s390/dasd: Add range-based format-track collision detectiondrivers/s390/block/dasd.c drivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_int.h+81 -290 replies
10/19s390/dasd: Extend prepare_itcw() to support WRITE_FULL_TRACKdrivers/s390/block/dasd_eckd.c+51 -130 replies
11/19s390/dasd: Add dasd_eckd_build_cp_tpm_writefulltrack()drivers/s390/block/dasd_eckd.c+343 -10 replies
12/19s390/dasd: Use WRITE_FULL_TRACK in ESE format handlerdrivers/s390/block/dasd.c drivers/s390/block/dasd_3990_erp.c drivers/s390/block/dasd_eckd.c +2 more+193 -800 replies
13/19s390/dasd: Add full_track_bias to control fulltrack write modedrivers/s390/block/dasd_devmap.c drivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_int.h+88 -50 replies
14/19s390/dasd: Derive adaptive ESE fulltrack heuristic from ft_biasdrivers/s390/block/dasd_devmap.c drivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_int.h+223 -60 replies
15/19s390/dasd: Stamp a format label into newly formatted volumesdrivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_eckd.h+114 -50 replies
16/19s390/dasd: Detect ESE volumes from the on-disk format labeldrivers/s390/block/dasd_devmap.c drivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_eckd.h +1 more+175 -150 replies
17/19s390/dasd: Report ESE capability and format mode at device onlinedrivers/s390/block/dasd_eckd.c+18 -30 replies
18/19s390/dasd: Re-enable discard support for ESE volumesdrivers/s390/block/dasd.c drivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_int.h+166 -430 replies
19/19s390/dasd: Read cached unit address and LSS in the CCW build pathdrivers/s390/block/dasd_eckd.c drivers/s390/block/dasd_eckd.h+24 -100 replies

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by.

PatchJan Höppner
1/19R-b
2/19R-b
3/19R-b
4/19R-b
5/19R-b
6/19R-b
7/19R-b
8/19R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/19] s390/dasd: ESE Performance improvements

Hello Jens,

please apply the patch series for the upcoming merge window. It applies onto your for-next branch.

The series significantly improves the performance and overall usability of Extent Space Efficient (ESE, aka thin provisioned) DASD devices.

On a freshly provisioned ESE volume I get the following throughput improvements, depending on workload and setup:

workload change
raw seq 1 MiB writes ~53x
fs bulk-load (xfs, buffered) ~49x
raw seq full-track (48k) ~3.7x
raw random 4k writes ~1.3x
control: fully-allocated vol ~0% (no regression)
(fresh quick-formatted ESE volume, 4 jobs, iodepth 16, median of 3)

The first 4 patches are fixes for existing bugs in this area, afterwards the infrastructure for and usage of Full Track Writes is added to the driver as well as an improved collision detection. The other patches add some tuning parameters and output as well as a new on disk format label.

FWIW: The series has been reviewed by Sashiko before. The remaining findings are pre existing bugs that will be assessed and addressed separately, false positives that are not a bug or not valid for ECKD DASD devices, in-between-patch findings that are resolved at the tip of the series, or accepted limitations.

Thanks,
Stefan

Stefan Haberland (19):
s390/dasd: Do not complete a failed ESE read as successful s390/dasd: Propagate partial completion length across ERP recovery s390/dasd: Guard sysfs discipline callbacks against unallocated
private data
s390/dasd: Snapshot intrc before freeing the request block s390/dasd: Optimize max blocks per request for track alignment s390/dasd: Use GFP_KERNEL in dasd_alloc_device() s390/dasd: Add defines for the Extended Address Volume track address s390/dasd: Add infrastructure for ESE full-track write s390/dasd: Add range-based format-track collision detection s390/dasd: Extend prepare_itcw() to support WRITE_FULL_TRACK s390/dasd: Add dasd_eckd_build_cp_tpm_writefulltrack() s390/dasd: Use WRITE_FULL_TRACK in ESE format handler s390/dasd: Add full_track_bias to control fulltrack write mode s390/dasd: Derive adaptive ESE fulltrack heuristic from ft_bias s390/dasd: Stamp a format label into newly formatted volumes s390/dasd: Detect ESE volumes from the on-disk format label s390/dasd: Report ESE capability and format mode at device online s390/dasd: Re-enable discard support for ESE volumes s390/dasd: Read cached unit address and LSS in the CCW build path

 drivers/s390/block/dasd.c          |  242 ++++--
 drivers/s390/block/dasd_3990_erp.c |    1 +
 drivers/s390/block/dasd_devmap.c   |   90 +-
 drivers/s390/block/dasd_eckd.c     | 1263 +++++++++++++++++++++++++---
 drivers/s390/block/dasd_eckd.h     |   68 +-
 drivers/s390/block/dasd_erp.c      |   11 +-
 drivers/s390/block/dasd_int.h      |  149 +++-
 7 files changed, 1625 insertions(+), 199 deletions(-)
Signature · 1 line
2.53.0