Skip to content

environment: clean up repository config handling

Tian Yuchen git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 7 repliesIn review
  2. v23 patches 3 repliesSuperseded
  3. v13 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- in the commit message of patch 1/3, explain why NULL repository is not allowed.

- in patch 2/3, mention in the comment that NULL repository shouldn't be passed in.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3environment: drop redundant NULL checks in config gettersenvironment.c+9 -91 reply
2/3environment: clarify repository config getter documentationenvironment.h+4 -110 replies
3/3environment: remove inaccurate repo_config_values commentsenvironment.h+0 -50 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchChristian CouderAyush ChandekarOlamide Caleb Bello
1/3Mentored-by Mentored-by Mentored-by
2/3Mentored-by Mentored-by Mentored-by
3/3Mentored-by Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/3] environment: clean up repository config handling

Hi all,

This series contains several cleanup patches for repository configuration handling.

No functional changes are intended. The patches make the related code more consistent and easier to maintain by improving documentation, formatting, and the organization of repo_config_values.

RFC:
If there are other small cleanups in this area that would be useful to include, suggestions are welcome.

Regards, yuchen

Changes since v2:

- in the commit message of patch 1/3, explain why NULL repository is not allowed.

- in patch 2/3, mention in the comment that NULL repository shouldn't be passed in.

Tian Yuchen (3):
environment: drop redundant NULL checks in config getters
environment: clarify repository config getter documentation
environment: remove inaccurate repo_config_values comments

 environment.c | 18 +++++++++---------
 environment.h | 20 ++++----------------
 2 files changed, 13 insertions(+), 25 deletions(-)
Signature · 1 line
2.43.0