ASoC: tegra: sort the reg_defaults tables
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | ASoC: tegra210_i2s: sort the register default tablesound/ | +1 | 0 replies | |
| 2/3 | ASoC: tegra210_i2s: sort the Tegra264 register default tablesound/ | +3 | 0 replies | |
| 3/3 | ASoC: tegra210_mixer: sort the register default tablesound/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] ASoC: tegra: sort the reg_defaults tables
reg_defaults must be sorted by ascending register address, since regcache_lookup_reg() locates entries in it with bsearch(). When a table is not sorted, bsearch() cannot find the entries which follow a descending step, so regcache_reg_needs_sync() falls back to reporting that a sync is needed for them. Those registers are then written to the device on every regcache_sync() even when they were never touched.
See commit fd80df352ba1 ("regcache: Add support for sorting defaults arrays") for the same problem in a different context.
The series is based on broonie/for-linus (05eebef3c7b2).
Affected tables:
tegra210_i2s_reg_defaults 2 of 8 entries unreachable tegra264_i2s_reg_defaults 4 of 9 entries unreachable tegra210_mixer_reg_defaults 1 entry unreachable
Peter Ujfalusi (3):
ASoC: tegra210_i2s: sort the register default table
ASoC: tegra210_i2s: sort the Tegra264 register default table
ASoC: tegra210_mixer: sort the register default table
sound/soc/tegra/tegra210_i2s.c | 8 ++++---- sound/soc/tegra/tegra210_mixer.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.55.0