PAES - Fix rc handling at skcipher_walk_done
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 4 repliesIn review
- v11 patch 0 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | s390/crypto: Fix return code handling at skcipher_walk_done in PAES algorithmsarch/ | +27 | 2 replies | |
| 2/2 | s390/crypto: Explicit scrub temp buffer in PAES ctr mode algorithmarch/ | +1 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Finn Callies | Holger Dengler |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] PAES - Fix rc handling at skcipher_walk_done
All the 4 PAES cipher processing loops were not checking the return value of skcipher_walk_done() immediately after calling it. This could lead to error masking when both the walk operation failed and a subsequent key conversion was needed (k < n condition).
Add immediate error checks after skcipher_walk_done() in all main processing loops (ECB, CBC, CTR, XTS modes) to ensure walk errors are properly propagated and not masked by subsequent operations.
Patch #2 deals with a not scrubbed temp buffer.
Changelog:
v1: initial patch
v2: - Sashiko found that now there is a possibility to double
de-allocate resources held by the walk. So another check if the walk has already been finalized is now part of the patch.
- Sashiko also stumbled over a not scrubbed temp buffer with the PAES ctr mode implementation. So another patch added which scrubs this buffer.
Harald Freudenberger (2):
s390/crypto: Fix return code handling at skcipher_walk_done in PAES
algorithms
s390/crypto: Explicit scrub temp buffer in PAES ctr mode algorithm
arch/s390/crypto/paes_s390.c | 39 ++++++++++++++++++++++++++---------- 1 file changed, 28 insertions(+), 11 deletions(-)
--
2.43.0