Skip to content

drivers/s390/net: Enable CONTEXT_ANALYSIS

Heiko Carstens linux-s390 netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2s390/ctcm: Add __context_unsafe() attribute to various functionsdrivers/s390/net/ctcm_fsms.c drivers/s390/net/ctcm_mpc.c+9 -170 repliesApplied
2/2drivers/s390/net: Enable CONTEXT_ANALYSISdrivers/s390/net/Makefile+2 -00 repliesApplied

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlexandra WinterSimon Horman
SeriesA-b R-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/2] drivers/s390/net: Enable CONTEXT_ANALYSIS

Enable CONTEXT_ANALYSYS for drivers/s390/net.

Static code checking for acquiring and releasing locks used to be done with sparse. That was removed with [1] and replaced with a clang based approach [2]. The new approach requires that each subsystem needs to be explicitly enabled for checking.

Do that for drivers/s390/net. In order to avoid false positives due to conditional locking, disable context analysis for specific functions of the ctcm driver. All comments in ctcm indicate that the code should stay as it is, and that such warnings should be ignored.

Disabling context analysis for specific functions keeps analysis enabled for the rest of a file.

[1] 5b63d0ae94cc ("compiler-context-analysis: Remove Sparse support")
[2] 3269701cb256 ("compiler-context-analysis: Add infrastructure for Context Analysis with Clang")

Heiko Carstens (2):
s390/ctcm: Add __context_unsafe() attribute to various functions drivers/s390/net: Enable CONTEXT_ANALYSIS

 drivers/s390/net/Makefile    |  2 ++
 drivers/s390/net/ctcm_fsms.c | 20 +++++++-------------
 drivers/s390/net/ctcm_mpc.c  |  6 ++----
 3 files changed, 11 insertions(+), 17 deletions(-)
Signature · 1 line
2.53.0