Skip to content

ASoC: rockchip: Simplify probe error handling

[email protected] linux-arm-kernel linux-rockchip linux-sound lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14ASoC: rockchip: rk3288_hdmi_analog: Drop redundant probe error messagessound/soc/rockchip/rk3288_hdmi_analog.c+2 -70 replies
2/14ASoC: rockchip: rk3288_hdmi_analog: Use dev_err_probe() for error handlingsound/soc/rockchip/rk3288_hdmi_analog.c+3 -40 replies
3/14ASoC: rockchip: rockchip_i2s: Use dev_err_probe() for error handlingsound/soc/rockchip/rockchip_i2s.c+6 -80 replies
4/14ASoC: rockchip: rockchip_i2s: Drop redundant probe error messagessound/soc/rockchip/rockchip_i2s.c+2 -60 replies
5/14ASoC: rockchip: rockchip_i2s: Propagate -EPROBE_DEFER from devm_pinctrl_get()sound/soc/rockchip/rockchip_i2s.c+5 -30 replies
6/14ASoC: rockchip: i2s-tdm: Inline PTR_ERR() in dev_err_probe()sound/soc/rockchip/rockchip_i2s_tdm.c+2 -40 replies
7/14ASoC: rockchip: i2s-tdm: Drop redundant probe error messagessound/soc/rockchip/rockchip_i2s_tdm.c+2 -70 replies
8/14ASoC: rockchip: rockchip_max98090: Drop redundant probe error messagessound/soc/rockchip/rockchip_max98090.c+1 -40 replies
9/14ASoC: rockchip: rockchip_pdm: Drop redundant probe error messagessound/soc/rockchip/rockchip_pdm.c+2 -60 replies
10/14ASoC: rockchip: rockchip_rt5645: Drop redundant probe error messagessound/soc/rockchip/rockchip_rt5645.c+1 -40 replies
11/14ASoC: rockchip: rockchip_sai: Propagate -EPROBE_DEFER from IRQ lookupsound/soc/rockchip/rockchip_sai.c+2 -00 replies
12/14ASoC: rockchip: rockchip_sai: Return the original error codesound/soc/rockchip/rockchip_sai.c+2 -30 replies
13/14ASoC: rockchip: rockchip_sai: Drop redundant probe error messagessound/soc/rockchip/rockchip_sai.c+2 -60 replies
14/14ASoC: rockchip: spdif: Return the original error codesound/soc/rockchip/rockchip_spdif.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] ASoC: rockchip: Simplify probe error handling

From: bui duc phuc <[email protected]>

Hi all,

This series simplifies probe error handling across Rockchip ASoC drivers.

It replaces open-coded error handling with dev_err_probe() where appropriate, removes redundant probe error messages, returns the original error code directly, and fixes handling of -EPROBE_DEFER returned by platform_get_irq_optional() in the Rockchip SAI driver and devm_pinctrl_get() in the Rockchip I2S driver.

Compile tested only.

Best regards,
Phuc

bui duc phuc (14):
ASoC: rockchip: rk3288_hdmi_analog: Drop redundant probe error
messages
ASoC: rockchip: rk3288_hdmi_analog: Use dev_err_probe() for error
handling
ASoC: rockchip: rockchip_i2s: Use dev_err_probe() for error handling
ASoC: rockchip: rockchip_i2s: Drop redundant probe error messages
ASoC: rockchip: rockchip_i2s: Propagate -EPROBE_DEFER from
devm_pinctrl_get()
ASoC: rockchip: i2s-tdm: Inline PTR_ERR() in dev_err_probe()
ASoC: rockchip: i2s-tdm: Drop redundant probe error messages
ASoC: rockchip: rockchip_max98090: Drop redundant probe error messages
ASoC: rockchip: rockchip_pdm: Drop redundant probe error messages
ASoC: rockchip: rockchip_rt5645: Drop redundant probe error messages
ASoC: rockchip: rockchip_sai: Propagate -EPROBE_DEFER from IRQ lookup
ASoC: rockchip: rockchip_sai: Return the original error code
ASoC: rockchip: rockchip_sai: Drop redundant probe error messages
ASoC: rockchip: spdif: Return the original error code

 sound/soc/rockchip/rk3288_hdmi_analog.c | 16 +++++--------
 sound/soc/rockchip/rockchip_i2s.c       | 30 +++++++++++--------------
 sound/soc/rockchip/rockchip_i2s_tdm.c   | 15 ++++---------
 sound/soc/rockchip/rockchip_max98090.c  |  5 +----
 sound/soc/rockchip/rockchip_pdm.c       |  8 ++-----
 sound/soc/rockchip/rockchip_rt5645.c    |  5 +----
 sound/soc/rockchip/rockchip_sai.c       | 15 +++++--------
 sound/soc/rockchip/rockchip_spdif.c     |  4 ++--
 8 files changed, 34 insertions(+), 64 deletions(-)
Signature · 1 line
2.43.0