Skip to content

EDAC/altera: Guard against NULL of_node

Dinh Nguyen linux-edac lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1EDAC/altera: Guard against NULL of_node pointer dereferencedrivers/edac/altera_edac.c+9 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] EDAC/altera: Guard against NULL of_node

Hi EDAC maintainers,

I wanted to explain the reason why I think this patch doesn't need a Fixes tag. The way the Altera EDAC is written there are many instances of the driver referencing the of_node, which is why they are flagged in many sashiko reviews.

This patch checks for those NULL of_node in the probe functions using dev_of_node() so we don't have to guard the of_node in all the other functions.

The reason we don't need the Fixes tag is because this system is supposed to run with CONFIG_OF enabled. The system would fail way before it gets to this driver if an of_node is not found. Thus I don't see a need for a Fixes tag but the guard should be in place for completeness.

Thanks,

Dinh Nguyen (1):
EDAC/altera: Guard against NULL of_node pointer dereference

 drivers/edac/altera_edac.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
Signature · 1 line
2.42.0.411.g813d9a9188