Skip to content

RFC an extensible SetUIInfo2 design

Chengyang Zhu qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1ui/dbus: add extensible SetUIInfo2 methodui/dbus-console.c ui/dbus-display1.xml+73 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/1] an extensible SetUIInfo2 design

Currently, the SetUIInfo method cannot set a refresh rate. Simply adding a refresh_rate argument would break the method signature.

This RFC adds the SetUIInfo2 method and QemuUIInfoTypes property.
* SetUIInfo2 takes a dictionary,
allowing partial updates and adding more keys in the future.
* QemuUIInfoTypes exposes the schema of SetUIInfo2's argument.

This patch is a proof-of-concept and it needs further discussion on:
* public API design (the name and the signature)
* partial update behavior (only updating the recognized fields)
* error handling (ignore the wrong keys or return an error?)

Test results:
* qemu:qtest-x86_64/dbus-display-test passed
* qemu:qtest-x86_64/dbus-vmstate-test passed
* qemu:qtest-x86_64/dbus-vnc-test SKIP
* manually created a virtual machine
and successfully set its refresh rate and resolution via SetUIInfo2

Chengyang Zhu (1):
ui/dbus: add extensible SetUIInfo2 method

 ui/dbus-console.c    | 56 ++++++++++++++++++++++++++++++++++++++++++++
 ui/dbus-display1.xml | 17 ++++++++++++++
 2 files changed, 73 insertions(+)
Signature · 1 line
2.55.0