iio: humidity: hts221: update probe and logging implementations
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest5 patches 4 repliesIn review
- v15 patches 10 repliesSuperseded
Changes in v2 from the cover letter
- Use a local 'dev' pointer instead of hw->dev in error logging helpers
- Fix punctuation in the commit message of patch 2/5
- Adjust commit message for patch 1/5 to include fixes due to ABI change of in_humidityrelative_oversampling_ratio_available
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | iio: humidity: hts221: report available values via read_avail()drivers/ | +40 | 0 replies | |
| 2/5 | iio: humidity: hts221: Add a blank line after variable declarationsdrivers/ | +1 | 0 replies | |
| 3/5 | iio: humidity: hts221: Allow unknown whoami for DT fallbackdrivers/ | +5 | 0 replies | |
| 4/5 | iio: humidity: hts221: use dev_err_probe() in probe pathsdrivers/ drivers/ drivers/ | +16 | 0 replies | |
| 5/5 | iio: humidity: hts221: fix division by zero in calibration parsingdrivers/ | +22 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Andy Shevchenko |
|---|---|
| Series | R-b |
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/5] iio: humidity: hts221: update probe and logging implementations
HTS221 is an older driver. This series groups a few small modernizations based on current development practices.
- Report available values via read_avail()
- Add a blank line after variable declarations (style)
- Allow unknown whoami for DT fallback instead of erroring out
- Use dev_err_probe() in probe paths
- Reject calibration data that would cause division by zero
No HTS221 hardware was available. Verified with checkpatch --strict and builds of hts221, hts221_i2c and hts221_spi. Probe and calibration error paths were exercised against i2c-stub with register contents pre-loaded via i2cset.
---
Changes in v2:
- Use a local 'dev' pointer instead of hw->dev in error logging helpers
- Fix punctuation in the commit message of patch 2/5
- Adjust commit message for patch 1/5 to include fixes due to ABI change of in_humidityrelative_oversampling_ratio_available
v1: https://lore.kernel.org/all/[email protected]/
Thanks to the reviewers for all the time you spent going through the code and the comments.
Adi Nata (5):
iio: humidity: hts221: report available values via read_avail()
iio: humidity: hts221: Add a blank line after variable declarations
iio: humidity: hts221: Allow unknown whoami for DT fallback
iio: humidity: hts221: use dev_err_probe() in probe paths
iio: humidity: hts221: fix division by zero in calibration parsing
drivers/iio/humidity/hts221_buffer.c | 1 + drivers/iio/humidity/hts221_core.c | 168 ++++++++++++--------------- drivers/iio/humidity/hts221_i2c.c | 11 +- drivers/iio/humidity/hts221_spi.c | 11 +- 4 files changed, 84 insertions(+), 107 deletions(-)
Signature · 1 line
2.47.3