Skip to content

s390/vfio-ap: Fix bugs in vfio_ap device driver callback functions

Anthony Krowiak kvm linux-s390 lkml sashiko-reviews stable 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest9 patches 6 repliesIn review
  2. v49 patches 4 repliesSuperseded
  3. v39 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v28 patches17 repliesSuperseded
v15 patches4 repliesSuperseded

Changes in v5 from the cover letter

~~~~~~~~~~~~~~~~~~~
Patch 8/9: Fix NULL deref in status_show() during queue probe
* Check if q = dev_get_drvdata(&apdev->device) actually returns a pointer to a vfio_ap_queue object. If not, the return AP_QUEUE_UNASSIGNED

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9s390/vfio-ap: Fix stale do_remove flag across iterations in vfio_ap_mdev_cfg_removedrivers/s390/crypto/vfio_ap_ops.c+4 -40 replies
2/9s390/vfio-ap: Fix dereference matrix_mdev->kvm without checking for NULLdrivers/s390/crypto/vfio_ap_ops.c+30 -90 replies
3/9s390/vfio-ap: Fix missing lock required to access list of ap_matrix_mdev objectsdrivers/s390/crypto/vfio_ap_ops.c+23 -40 replies
4/9s390/vfio-ap: Fix required lock not held during update of ap_matrix_mdev objectdrivers/s390/crypto/vfio_ap_ops.c+8 -01 reply
5/9s390/vfio-ap: Fix control domain removal in vfio_ap_mdev_cfg_removedrivers/s390/crypto/vfio_ap_ops.c+3 -30 replies
6/9s390/vfio-ap: fix potential use of uninitialized apm_filtered bitmapdrivers/s390/crypto/vfio_ap_ops.c+9 -00 replies
7/9s390/vfio-ap: Fix hot-unplug skipped when last AP adapter or domain removeddrivers/s390/crypto/vfio_ap_ops.c+17 -131 reply
8/9s390/vfio-ap: Fix NULL deref in status_show() during queue probedrivers/s390/crypto/vfio_ap_ops.c+29 -41 reply
9/9s390/vfio-ap: Fix memory leak when queue removed from host AP configdrivers/s390/crypto/vfio_ap_ops.c+4 -12 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchMatthew Rosato
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/9] s390/vfio-ap: Fix bugs in vfio_ap device driver callback functions

During review of patches by the Sashiko AI, several pre-existing bugs were discovered. This 9-patch series fixes those bugs.

Change log v4 => v5:
~~~~~~~~~~~~~~~~~~~
Patch 8/9: Fix NULL deref in status_show() during queue probe
* Check if q = dev_get_drvdata(&apdev->device) actually returns a pointer to a vfio_ap_queue object. If not, the return AP_QUEUE_UNASSIGNED

Anthony Krowiak (9):
s390/vfio-ap: Fix stale do_remove flag across iterations in
vfio_ap_mdev_cfg_remove
s390/vfio-ap: Fix dereference matrix_mdev->kvm without checking for
NULL
s390/vfio-ap: Fix missing lock required to access list of
ap_matrix_mdev objects
s390/vfio-ap: Fix required lock not held during update of
ap_matrix_mdev object
s390/vfio-ap: Fix control domain removal in vfio_ap_mdev_cfg_remove s390/vfio-ap: fix potential use of uninitialized apm_filtered bitmap s390/vfio-ap: Fix hot-unplug skipped when last AP adapter or domain
removed
s390/vfio-ap: Fix NULL deref in status_show() during queue probe s390/vfio-ap: Fix memory leak when queue removed from host AP config

 drivers/s390/crypto/vfio_ap_ops.c | 163 +++++++++++++++++++++++-------
 1 file changed, 126 insertions(+), 37 deletions(-)
Signature · 1 line
2.53.0