Skip to content

perf build: Add target to install devel packages needed to build perf

Arnaldo Carvalho de Melo linux-perf-users lkml 9 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest7 patches 2 repliesApplied
  2. v87 patches 0 repliesSuperseded
  3. v77 patches 1 replySuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v67 patches0 repliesSuperseded
v57 patches0 repliesSuperseded
v47 patches0 repliesSuperseded
v37 patches0 repliesSuperseded
v27 patches2 repliesSuperseded
v17 patches2 repliesSuperseded

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/7tools build: Only probe the compiler at parse time when it is installedtools/scripts/Makefile.arch tools/scripts/Makefile.include+14 -20 replies
2/7perf build: Add install-build-deps framework to install devel packagestools/perf/Makefile.perf tools/perf/scripts/install-build-deps.sh+190 -30 replies
3/7perf build: install-build-deps: add Fedora devel package mappingtools/perf/scripts/install-build-deps.sh+156 -230 replies
4/7perf build: install-build-deps: add Ubuntu devel package mappingtools/perf/Makefile.perf tools/perf/scripts/install-build-deps.sh+161 -410 replies
5/7perf build: install-build-deps: add Debian devel package mappingtools/perf/Makefile.perf tools/perf/scripts/install-build-deps.sh+22 -180 replies
6/7perf build: Remove leftover feature tests for removed cxx and clang supporttools/build/Makefile.feature tools/build/feature/Makefile+0 -160 replies
7/7perf build: install-build-deps: add RHEL family devel package mappingtools/perf/scripts/install-build-deps.sh+197 -230 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.

Read the v9 thread

Cover letter [PATCHES v9 0/7] perf build: Add target to install devel packages needed to build perf

Hi,

This series adds a 'make -C tools/perf install-build-deps' target that installs the development packages needed to build perf on Fedora, Ubuntu, Debian, and RHEL family distributions.

Building perf requires many devel packages (libelf, libdw, libunwind, numactl, libtraceevent, libbpf, etc.). Today users must iteratively install packages as each feature check fails. The new target installs the full set in one go.

The first patch makes the compiler probe run at parse time only when the tool is installed, so a missing C++ compiler or clang no longer fails the feature tests prematurely. The second patch adds the framework (make target, distro detection, package manager drivers). The next four patches add distro-specific package mappings derived from the headers each feature test requires. The last patch removes leftover feature test entries for cxx and clang support removed in 56b11a2126bf2f42 ("perf
bpf: Remove support for embedding clang for compiling BPF events (-e foo.c)").

Supported distros (validated in containers, host never modified):
- Fedora 44 (dnf, 29 packages)
- Ubuntu 26.04 (apt, 29 packages)
- Debian 13 (apt, reuses Ubuntu mapping)
- Centos 10 (dnf, 29 packages)

On all distros, a clean O= build after running the target enabled every feature the distro provides (excluding deliberately unmapped deprecated packages). Re-running the target is a no-op.

Best regards,

- Arnaldo

What changed from v8:

- the apt-get install command now runs with DEBIAN_FRONTEND=noninteractive: tzdata, pulled in by default-jdk for the jvmti feature tests, would block the install prompting for the timezone on a terminal, e.g. in a container shared with an interactive session, as the debconf prompt is not covered by the '-y' flag [sashiko review of PATCH 4/7];
- added comments addressing two false positives from that same
review: main() holds no per-feature package state, package_set() and the *_pkg_for() helpers declare their own 'pkg' locals (the unused one in main() was removed in v5), and an empty rhel_pkg_for() result means the feature test has no external devel dependency, not a silently dropped package: genuinely unavailable ones reach missing_pkgs through rhel_pkg_for()'s fallback candidates and the pkg_available() check [sashiko review of PATCH 4/7, 7/7];
- the temporary file tracking missing packages is already removed on SIGINT/SIGTERM by the EXIT/INT/TERM traps, with the comment making the interrupt path explicit [sashiko review of PATCH 7/7].

What changed from v7:

- added comments in tools/scripts/Makefile.arch and tools/scripts/Makefile.include explaining the 'command -v' guarded compiler probes, which are a fairly complex one-liner now [Ian Rogers review of PATCH 1/7].

What changed from v6:

- feature_tests() now strips the .c and .cpp suffixes with chained POSIX BRE substitutions (e.g. -e 's/\.c$//' -e 's/\.cpp$//') instead of \| alternation, a GNU sed extension that would fail on BSD sed hosts (macOS, FreeBSD), silently dropping feature-specific packages [sashiko review of PATCH 3/7].

What changed from v5:

- the unused 'pkg' local declaration was removed from main(): the iteration over packages happens in package_set(), which declares its own 'pkg' variable [sashiko review of PATCH 3/7];
- sourcing /etc/os-release in detect_distro() now redirects stderr with 2>/dev/null, so a missing /etc/os-release no longer prints an error message [sashiko review of PATCH 2/7].

What changed from v4:

- No changes from v3, just resubmitting because Sashiko restarted and when back it didn't manage to apply this even with the same base commit (perf-tools-next/perf-tools-next) as V3, so this probably is something transient, and as I'm addressing comments for v3, worth resubmitting.

What changed from v3:

- clear the EXIT/INT/TERM traps after consuming and removing the temp
file: missing_file is local to main(), so the EXIT trap firing after main() returns hits an unbound variable under set -u, printing a spurious error on the successful-install path [sashiko review of PATCH 7/7].

What changed from v2:

- the trap that removes the temporary file tracking missing packages now exits the script when SIGINT/SIGTERM is received, instead of only removing the file and letting the script resume after the interrupted command [sashiko review of PATCH 7/7].

What changed from v1:

- AlmaLinux is now detected by its actual /etc/os-release ID ("almalinux" instead of "alma") in detect_distro() [sashiko review of PATCH 7/7];
- packages that no enabled repo provides (e.g. zlib and the versioned JDK/jvmti packages on the RHEL family) are no longer silently omitted from the missing packages list, they are reported at the end of the run, as stated in the commit message [sashiko review of PATCH 7/7];
- the temporary file used to track those missing packages is now removed by a trap, so it does not leak if the script is interrupted [sashiko review of PATCH 7/7];
- the leftover feature test removal patch now carries the suggested
Fixes: tag for 56b11a2126bf2f42, with the author of that commit Cc'd [Ian Rogers review of PATCH 6/7].

This series was developed with assistance from Opencode (deepseek-v4-flash-free and glm-4-7-flash-ollama-local) for code analysis, patch generation, and commit message composition, and from Claude (Opus 4.7) for review triage and bug-fix generation.

Arnaldo Carvalho de Melo (7):
tools build: Only probe the compiler at parse time when it is installed perf build: Add install-build-deps framework to install devel packages perf build: install-build-deps: add Fedora devel package mapping perf build: install-build-deps: add Ubuntu devel package mapping perf build: install-build-deps: add Debian devel package mapping perf build: Remove leftover feature tests for removed cxx and clang support perf build: install-build-deps: add RHEL family devel package mapping

 tools/build/Makefile.feature             |   2 -
 tools/build/feature/Makefile             |  14 -
 tools/perf/Makefile.perf                 |  21 +-
 tools/perf/scripts/install-build-deps.sh | 603 +++++++++++++++++++++++++++++++
 tools/scripts/Makefile.arch              |   8 +-
 tools/scripts/Makefile.include           |   8 +-
 6 files changed, 635 insertions(+), 21 deletions(-)

base-commit: bf10e6ee2ac3034c9068e03eed418fd16961984e
v8-head: a2b6e139224899db59263b8636d7b01690049eab
v7-head: ca62b23f83ddfb8e
v6-head: 39460c4a24830619
v5-head: f76189ae44f2b5bc
v3-head: 1676d9c5fe7ba0a1
v2-head: 7eec75d1744ccf83