Rework PCI IRQ vector code
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 3 repliesApplied
- v25 patches 15 repliesSuperseded
- v15 patches 3 repliesSuperseded
Changes in v3 from the cover letter
- Rename s/count/len/, s/vector()/index()/, s/vector_count()/len()/.
- Remove redundant range check in index().
- Add missing #[inline].
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | rust: pci: convert IrqVectorRegistration to a lifetime-managed owning typerust/ rust/ | +70 | 0 replies | |
| 2/5 | rust: pci: resolve IRQ in index() and embed IrqRequest in IrqVectorrust/ | +23 | 1 reply | |
| 3/5 | rust: pci: remove request_irq() and request_threaded_irq() from Devicerust/ | +5 | 0 replies | |
| 4/5 | PCI: Add pci_irq_type() to query the allocated interrupt typeinclude/ | +25 | 0 replies | |
| 5/5 | rust: pci: expose the allocated interrupt typerust/ rust/ | +28 | 0 replies |
Reviews trailers per patch
1 of 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | John Hubbard | Bjorn Helgaas | Gary Guo |
|---|---|---|---|
| Series | R-b | ||
| 1/5 | T-b | ||
| 2/5 | T-b Inspired-by | ||
| 3/5 | T-b | ||
| 4/5 | T-b Inspired-by | A-b | |
| 5/5 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/5] Rework PCI IRQ vector code
This series reworks the Rust PCI interrupt vector abstractions, motivated by review feedback on the nova-core interrupt support series [1].
Convert IrqVectorRegistration to a lifetime-managed owning type, replacing the devres-based approach. Since index() borrows the registration, the returned IrqVector inherits that lifetime, preventing the allocation from being dropped while any handler is live.
IrqVector embeds a resolved IrqRequest, making the conversion infallible. The request_irq()/request_threaded_irq() wrappers on Device are removed since their &self receiver could refer to an unrelated device.
Add pci_irq_type() as a C function in include/linux/pci.h, replacing open-coded checks across drivers [2], and wrap it for Rust.
[1] https://lore.kernel.org/all/[email protected]/
[2] https://elixir.bootlin.com/linux/v7.1/source/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c#L196
Changes in v3:
- Rename s/count/len/, s/vector()/index()/, s/vector_count()/len()/.
- Remove redundant range check in index().
- Add missing #[inline].
Changes in v2:
- Drop the IrqRequestAnchor approach and keep IrqVector as a new type over IrqRequest.
Danilo Krummrich (5):
rust: pci: convert IrqVectorRegistration to a lifetime-managed owning
type
rust: pci: resolve IRQ in index() and embed IrqRequest in IrqVector
rust: pci: remove request_irq() and request_threaded_irq() from Device
PCI: Add pci_irq_type() to query the allocated interrupt type
rust: pci: expose the allocated interrupt type
include/linux/pci.h | 25 +++++ rust/helpers/pci.c | 5 + rust/kernel/pci.rs | 3 +- rust/kernel/pci/irq.rs | 220 ++++++++++++++++++----------------------- 4 files changed, 128 insertions(+), 125 deletions(-)
base-commit: dbaafe9cc56a996931eedfe043eb34418cc9cd9b
Signature · 1 line
2.55.0