Skip to content

KVM: s390: And then... even more fixes again

Claudio Imbrenda kvm linux-s390 lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 11 repliesIn review
  2. v111 patches 11 repliesSuperseded

Changes in v2 from the cover letter

* Use the srcu only around kvm_s390_inject_vcpu()
* Wildly simplify the third patch: introduce gisa_test_ipm_gisc() and use it in get_all_floating_irqs() instead of gisa_tac_ipm_gisc()
* Use set_page_dirty() instead of set_page_dirty_lock(). In all scenarios we are holding an extra reference to the page, we don't need to also lock. Also move things around a little to avoid races.
* Fix return value of kvm_arch_prepare_memory_region()
* Fix return value being overwritten in patch 8
* Drop patches 6 and 7, they need more thought

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9KVM: s390: Properly handle NULL pointer in dat_cond_set_storage_key()arch/s390/kvm/dat.c+4 -10 replies
2/9KVM: s390: Use srcu in kvm_arch_vcpu_unlocked_ioctl()arch/s390/kvm/kvm-s390.c+4 -21 reply
3/9KVM: s390: Fix get_all_floating_irqs()arch/s390/kvm/interrupt.c+6 -12 replies
4/9KVM: s390: Fix dirty marking in adapter_indicators_set*()arch/s390/kvm/interrupt.c+27 -212 replies
5/9KVM: s390: Fix pgste_get_trylock_multiple()arch/s390/kvm/dat.c+2 -51 reply
6/9KVM: s390: Fix IRQ injection with SIGP Stop and Store Statusarch/s390/kvm/interrupt.c+38 -323 replies
7/9KVM: s390: Fix kvm_s390_clear_pv_state()arch/s390/kvm/pv.c+4 -01 reply
8/9KVM: s390: Fix potential tiny kernel stack leakarch/s390/kvm/dat.c+1 -01 reply
9/9KVM: s390: Fix _gaccess_shadow_fault()arch/s390/kvm/gaccess.c+10 -00 replies

Reviews trailers per patch

7 of 9 patches have a Reviewed-by or Acked-by.

PatchChristian BorntraegerChristoph Schlameuss
1/9R-b
2/9R-b R-b
3/9R-b R-b
4/9
5/9R-b R-b
6/9R-b
7/9R-b A-b
8/9R-b R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] KVM: s390: And then... even more fixes again

Another round of mostly unrelated misc fixes.

Mostly small and/or unlikely issues, but they needed to be addressed.

v1->v2:
* Use the srcu only around kvm_s390_inject_vcpu()
* Wildly simplify the third patch: introduce gisa_test_ipm_gisc() and use it in get_all_floating_irqs() instead of gisa_tac_ipm_gisc()
* Use set_page_dirty() instead of set_page_dirty_lock(). In all scenarios we are holding an extra reference to the page, we don't need to also lock. Also move things around a little to avoid races.
* Fix return value of kvm_arch_prepare_memory_region()
* Fix return value being overwritten in patch 8
* Drop patches 6 and 7, they need more thought

Claudio Imbrenda (9):
KVM: s390: Properly handle NULL pointer in dat_cond_set_storage_key()
KVM: s390: Use srcu in kvm_arch_vcpu_unlocked_ioctl()
KVM: s390: Fix get_all_floating_irqs()
KVM: s390: Fix dirty marking in adapter_indicators_set*()
KVM: s390: Fix pgste_get_trylock_multiple()
KVM: s390: Fix IRQ injection with SIGP Stop and Store Status
KVM: s390: Fix kvm_s390_clear_pv_state()
KVM: s390: Fix potential tiny kernel stack leak
KVM: s390: Fix _gaccess_shadow_fault()

 arch/s390/kvm/dat.c       |  13 ++--
 arch/s390/kvm/gaccess.c   |  10 +++
 arch/s390/kvm/interrupt.c | 125 ++++++++++++++++++++++----------------
 arch/s390/kvm/kvm-s390.c  |   6 +-
 arch/s390/kvm/pv.c        |   4 ++
 5 files changed, 96 insertions(+), 62 deletions(-)
Signature · 1 line
2.55.0