Skip to content

ionic: fix completion descriptor access

Eric Joyner netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2ionic: add missing dma_rmb() after the completion publish checkdrivers/net/ethernet/pensando/ionic/ionic_main.c drivers/net/ethernet/pensando/ionic/ionic_txrx.c+8 -00 repliesApplied
2/2ionic: fix completion descriptor access with 2x desc sizedrivers/net/ethernet/pensando/ionic/ionic_txrx.c+14 -130 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBrett CreeleySimon Horman
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/2] ionic: fix completion descriptor access

The first patch adds the missing dma_rmb() between the completion publish checks and the reads of the descriptor payloads, suggested by the Sashiko review from [1] for the second patch.

The second locates the completion within its slot from cq->desc_size rather than a fixed stride, which is necessary when IONIC_Q_F_2X_CQ_DESC (double-sized completion descriptors) is used (e.g. for hardware timestamps).

[1] https://lore.kernel.org/netdev/[email protected]/

Eric Joyner (1):
ionic: add missing dma_rmb() after the completion publish check

Prabu Thayalan (1):
ionic: fix completion descriptor access with 2x desc size

 .../net/ethernet/pensando/ionic/ionic_main.c  |  4 +++
 .../net/ethernet/pensando/ionic/ionic_txrx.c  | 31 +++++++++++--------
 2 files changed, 22 insertions(+), 13 deletions(-)

base-commit: 53658c6f3682967a5e76ed4bc7462c4bdcddaec3

Signature · 1 line
2.43.0