memcg: remove the v1 soft limit
Status from this message: [merged mm-stable] memcg-simplify-v1-event-ratelimiting.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest8 patches 1 replyApplied 8/8
- v19 patches 18 repliesSuperseded 1 of 9 applied
Patches in v2 All 8 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | memcg: remove v1 soft limit reclaiminclude/ mm/ mm/ | +6 | 0 replies | Applied |
| 2/8 | memcg: remove mem_cgroup_shrink_node()mm/ mm/ | +0 | 0 replies | Applied |
| 3/8 | memcg: remove the soft limit reclaim tracepointsinclude/ | +0 | 0 replies | Applied |
| 4/8 | memcg: remove the soft limit rbtreemm/ mm/ mm/ | +2 | 0 replies | Applied |
| 5/8 | memcg: remove lru_gen_soft_reclaim()include/ mm/ | +13 | 0 replies | Applied |
| 6/8 | memcg: remove the per-node soft limit tree fieldsinclude/ | +0 | 0 replies | Applied |
| 7/8 | memcg: remove mem_cgroup->soft_limitinclude/ mm/ mm/ | +0 | 0 replies | Applied |
| 8/8 | memcg: simplify v1 event ratelimitingmm/ mm/ mm/ | +14 | 0 replies | Applied |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Michal Hocko | Lorenzo Stoakes (ARM) | T.J. Mercier |
|---|---|---|---|
| 1/8 | A-b | A-b | |
| 2/8 | A-b | A-b | |
| 3/8 | A-b | A-b | |
| 4/8 | A-b | A-b | |
| 5/8 | A-b | R-b | |
| 6/8 | A-b | A-b | |
| 7/8 | A-b | A-b | |
| 8/8 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/8] memcg: remove the v1 soft limit
The v1 soft limit was deprecated in v6.12 by commit 569c4f62d84a ("memcg:
initiate deprecation of v1 soft limit") and nobody has reported depending on it in the ~21 months since. memory.low and memory.min in v2 have covered the same ground for far longer.
The knob has since been made inert by "memcg: make the v1 soft limit knob inert", already queued in mm-hotfixes as a backportable fix for a syzbot report [1]. Nothing can enter the soft limit rbtree anymore, so this series just deletes the machinery that is now dead: the reclaim pass in kswapd and direct reclaim, mem_cgroup_shrink_node() and its tracepoints, the per-node rbtree, lru_gen_soft_reclaim() and the MEMCG_LRU_HEAD op, the per-node tree fields, mem_cgroup->soft_limit, and finally the v1 event ratelimiting which is now down to a single target.
memory.soft_limit_in_bytes itself is untouched: writes stay ignored and reads keep returning the maximum value.
Changes since v1 [2]:
- Dropped "memcg: make the v1 soft limit knob inert" (1/9 in v1), which is already queued in mm-hotfixes, making this an 8-patch series.
- Collected the acks and review tags. No code changes.
Sashiko's v1 review [3] asked whether the softlimit tracepoints, lru_gen_soft_reclaim(), the per-node tree fields and the MEM_CGROUP_TARGET_SOFTLIMIT ratelimiting could go too. They all can and they all do, in patches 3/8, 5/8, 6/8 and 8/8 of this same series.
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://sashiko.dev/#/patchset/[email protected]
Shakeel Butt (8):
memcg: remove v1 soft limit reclaim
memcg: remove mem_cgroup_shrink_node()
memcg: remove the soft limit reclaim tracepoints
memcg: remove the soft limit rbtree
memcg: remove lru_gen_soft_reclaim()
memcg: remove the per-node soft limit tree fields
memcg: remove mem_cgroup->soft_limit
memcg: simplify v1 event ratelimiting
include/linux/memcontrol.h | 27 --- include/linux/mmzone.h | 30 +-- include/trace/events/vmscan.h | 14 -- mm/internal.h | 4 - mm/memcontrol-v1.c | 392 ++-------------------------------- mm/memcontrol-v1.h | 12 +- mm/memcontrol.c | 7 +- mm/vmscan.c | 96 +-------- 8 files changed, 34 insertions(+), 548 deletions(-)
Signature · 1 line
2.53.0-Meta