Skip to content

mptcp: MIB counter for invalid option

Gang Yan mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mptcp: pass net namespace to options parsernet/mptcp/options.c net/mptcp/protocol.h net/mptcp/subflow.c+11 -100 replies
2/2mptcp: add MIB counter for received invalid optionsnet/mptcp/mib.c net/mptcp/mib.h net/mptcp/options.c+74 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH mptcp-next 0/2] mptcp: MIB counter for invalid option

From: Gang Yan <[email protected]>

This series is designed for [1].

Patch 1 passes the 'net' to options parser, I used to use dev_net(skb->dev) for MIB counters, but the AI reported it is not suitable for this. This patch has no functional change.

Patch 2 adds the InvalidOptionRx counter, and increments it when receive the invalid options.

The packetdill testcase is submitted, and can be reviewed in [2].

[1] https://github.com/multipath-tcp/mptcp_net-next/issues/628
[2] https://github.com/multipath-tcp/packetdrill/pull/205
Gang Yan (2):
mptcp: pass net namespace to options parser
mptcp: add MIB counter for received invalid options

 net/mptcp/mib.c      |   1 +
 net/mptcp/mib.h      |   1 +
 net/mptcp/options.c  | 107 +++++++++++++++++++++++++++++++------------
 net/mptcp/protocol.h |   2 +-
 net/mptcp/subflow.c  |  10 ++--
 5 files changed, 85 insertions(+), 36 deletions(-)
Signature · 1 line
2.43.0