monitor: Reduce headers included in 'monitor/monitor.h'
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest23 patches 13 repliesIn review
- v216 patches 17 repliesSuperseded
- v114 patches 1 replySuperseded
Changes in v3 from the cover letter
- Fixed net/vhost-vdpa (new patch)
- Use QOM-cast macros (bonus)
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/23 | hexagon: Remove unnecessary 'monitor/monitor.h' headerinclude/ target/ | +3 | 0 replies | |
| 2/23 | net/vhost-vdpa: Include missing 'qemu/iov.h' headernet/ | +1 | 2 replies | |
| 3/23 | tests/unit: Include 'qemu/main-loop.h' header in test-util-sockets.ctests/ | +1 | 0 replies | |
| 4/23 | qapi/qmp-dispatch: Include 'qemu/aio-wait.h' and 'monitor/monitor.h'qapi/ | +2 | 0 replies | |
| 5/23 | qapi/qmp-registry: Remove unnecessary 'monitor/monitor.h' headerinclude/ | +0 | 0 replies | |
| 6/23 | migration/hmp-cmds: Include 'block/block-global-state.h' headermigration/ | +1 | 1 reply | |
| 7/23 | monitor: Include missing 'qemu/aio-wait.h' headermonitor/ monitor/ | +2 | 0 replies | |
| 8/23 | monitor: Include missing 'qemu/lockable.h' headermonitor/ monitor/ monitor/ | +3 | 0 replies | |
| 9/23 | monitor: Include missing 'qemu/coroutine-core.h' headerinclude/ | +1 | 0 replies | |
| 10/23 | monitor: Reduce inclusion of 'qapi/qapi-emit-events.h' headerinclude/ monitor/ | +1 | 0 replies | |
| 11/23 | monitor: Remove unnecessary 'block/block.h' headerinclude/ | +0 | 1 reply | |
| 12/23 | system: Remove unnecessary 'monitor/monitor.h' headersystem/ system/ | +0 | 0 replies | |
| 13/23 | system/dirtylimit: Extract HMP code to dirtylimit-hmp-cmds.cMAINTAINERS system/ system/ +1 more | +76 | 1 reply | |
| 14/23 | system: Move qmp_inject_nmi() to hw/core/machine-qmp-cmds.chw/ system/ | +6 | 0 replies | |
| 15/23 | system: Extract QMP memsave/pmemsave commands to physmem-qmp-cmds.cMAINTAINERS system/ system/ +1 more | +109 | 0 replies | |
| 16/23 | system: Move runstate-related code from cpus.c to runstate.csystem/ system/ | +154 | 0 replies | |
| 17/23 | monitor: Rename MonitorQMP @mon -> @qmonmonitor/ monitor/ monitor/ | +139 | 6 replies | |
| 18/23 | monitor: Rename MonitorHMP @mon -> @hmoninclude/ migration/ monitor/ +4 more | +96 | 0 replies | |
| 19/23 | monitor: Better express monitor_read()'s opaque arg is of Monitor typemonitor/ | +2 | 1 reply | |
| 20/23 | monitor: Use QOM MONITOR() macro to access MonitorQMP->parent_objmonitor/ | +28 | 0 replies | |
| 21/23 | monitor: Use QOM MONITOR() macro to access MonitorHMP->parent_objmonitor/ monitor/ | +30 | 0 replies | |
| 22/23 | monitor: Replace container_of(MonitorHMP, parent_obj) -> MONITOR_HMP()monitor/ monitor/ ui/ | +4 | 1 reply | |
| 23/23 | monitor/hmp: Remove unnecessary 'monitor/monitor.h' headerinclude/ | +0 | 0 replies |
Reviews trailers per patch
18 of 23 patches have a Reviewed-by or Acked-by.
| Patch | Marc-André Lureau | Michael S. Tsirkin | Dr. David Alan Gilbert | Hyman Huang |
|---|---|---|---|---|
| 1/23 | R-b | |||
| 2/23 | R-b | A-b | ||
| 3/23 | R-b | |||
| 4/23 | R-b | |||
| 5/23 | R-b | |||
| 6/23 | R-b | R-b | ||
| 7/23 | R-b | |||
| 8/23 | R-b | |||
| 9/23 | R-b | |||
| 10/23 | R-b | |||
| 11/23 | R-b | |||
| 12/23 | R-b | |||
| 13/23 | R-b | R-b | ||
| 14/23 | R-b | |||
| 15/23 | R-b | |||
| 16/23 | R-b | |||
| 17/23 | ||||
| 18/23 | ||||
| 19/23 | R-b | |||
| 20/23 | ||||
| 21/23 | ||||
| 22/23 | R-b | |||
| 23/23 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v3 00/23] monitor: Reduce headers included in 'monitor/monitor.h'
Missing review: 2, 11, 17+
Since v2:
- Fixed net/vhost-vdpa (new patch)
- Use QOM-cast macros (bonus)
Since v1:
- extract QMP inject_nmi/memsave/pmemsave out of cpus.c (first 12 patches left unchanged).
Another HMP cleanup series to help Marc-André with his 'Make HMP optional' series [*].
We could also remove "exec/hwaddr.h" by moving gpa2hva() declaration elsewhere, and "qapi/qapi-types-misc.h" by moving monitor_fdset_add_fd() out to some "monitor/fdset.h" header.
[*] [email protected]
Based-on: <[email protected]>
Philippe Mathieu-Daudé (23):
hexagon: Remove unnecessary 'monitor/monitor.h' header net/vhost-vdpa: Include missing 'qemu/iov.h' header tests/unit: Include 'qemu/main-loop.h' header in test-util-sockets.c qapi/qmp-dispatch: Include 'qemu/aio-wait.h' and 'monitor/monitor.h' qapi/qmp-registry: Remove unnecessary 'monitor/monitor.h' header migration/hmp-cmds: Include 'block/block-global-state.h' header
monitor: Include missing 'qemu/aio-wait.h' header
monitor: Include missing 'qemu/lockable.h' header
monitor: Include missing 'qemu/coroutine-core.h' header
monitor: Reduce inclusion of 'qapi/qapi-emit-events.h' header
monitor: Remove unnecessary 'block/block.h' header
system: Remove unnecessary 'monitor/monitor.h' header system/dirtylimit: Extract HMP code to dirtylimit-hmp-cmds.c
system: Move qmp_inject_nmi() to hw/core/machine-qmp-cmds.c
system: Extract QMP memsave/pmemsave commands to physmem-qmp-cmds.c
system: Move runstate-related code from cpus.c to runstate.c
monitor: Rename MonitorQMP @mon -> @qmon
monitor: Rename MonitorHMP @mon -> @hmon
monitor: Better express monitor_read()'s opaque arg is of Monitor type
monitor: Use QOM MONITOR() macro to access MonitorQMP->parent_obj
monitor: Use QOM MONITOR() macro to access MonitorHMP->parent_obj
monitor: Replace container_of(MonitorHMP, parent_obj) -> MONITOR_HMP() monitor/hmp: Remove unnecessary 'monitor/monitor.h' header
MAINTAINERS | 2 + include/hw/hexagon/hexagon_tlb.h | 2 +- include/monitor/hmp.h | 1 - include/monitor/monitor.h | 7 +- include/qapi/qmp-registry.h | 1 - monitor/monitor-internal.h | 7 +- target/hexagon/hex_mmu.h | 3 +- hw/core/machine-qmp-cmds.c | 6 + migration/migration-hmp-cmds.c | 5 +- monitor/fds.c | 1 + monitor/hmp-cmds.c | 10 +- monitor/hmp.c | 164 ++++++++++--------- monitor/monitor.c | 2 + monitor/qmp-cmds-control.c | 18 +-- monitor/qmp-cmds.c | 13 +- monitor/qmp.c | 270 ++++++++++++++++--------------- net/vhost-vdpa.c | 1 + qapi/qmp-dispatch.c | 2 + system/cpus.c | 247 ---------------------------- system/device_tree.c | 1 - system/dirtylimit-hmp-cmds.c | 74 +++++++++ system/dirtylimit.c | 60 ------- system/physmem-qmp-cmds.c | 107 ++++++++++++ system/physmem.c | 2 - system/runstate.c | 154 ++++++++++++++++++ tests/unit/test-util-sockets.c | 1 + ui/ui-hmp-cmds.c | 6 +- system/meson.build | 2 + 28 files changed, 617 insertions(+), 552 deletions(-) create mode 100644 system/dirtylimit-hmp-cmds.c create mode 100644 system/physmem-qmp-cmds.c
Signature · 1 line
2.53.0