smb: client: Avoid leaking of sensitive data to the stack or heap
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | smb: client: Clear sensitive stack data in smb2transport.cfs/ | +4 | 3 replies | |
| 2/5 | smb: client: Clear sensitive stack and heap data in smb2ops.cfs/ | +2 | 0 replies | |
| 3/5 | smb: client: Clear sensitive stack data in cifsencrypt.cfs/ | +9 | 0 replies | |
| 4/5 | smb: client: Clear sensitive stack data in smb1encrypt.cfs/ | +9 | 3 replies | |
| 5/5 | smb: client: Avoid leaking sensitive data to the heap in connect.cfs/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] smb: client: Avoid leaking of sensitive data to the stack or heap
Similar to the patch series that I sent for the server code recently, here's a clean-up series for the client part:
Sensitive data like keys that are stored in stack-local arrays could be leaked via the stack to the calling functions, or via the heap when using only normal kfree() functions.
It's good security practice to clear sensitive data on the stack first with memzero_explicit() before leaving the context, and to use kfree_sensitive() for data that is returned to the heap.
Thomas Huth (5):
smb: client: Clear sensitive stack data in smb2transport.c
smb: client: Clear sensitive stack and heap data in smb2ops.c
smb: client: Clear sensitive stack data in cifsencrypt.c
smb: client: Clear sensitive stack data in smb1encrypt.c
smb: client: Avoid leaking sensitive data to the heap in connect.c
fs/smb/client/cifsencrypt.c | 12 +++++++++--- fs/smb/client/connect.c | 2 +- fs/smb/client/smb1encrypt.c | 19 +++++++++---------- fs/smb/client/smb2ops.c | 4 ++-- fs/smb/client/smb2transport.c | 4 ++++ 5 files changed, 25 insertions(+), 16 deletions(-)
Signature · 1 line
2.55.0