Skip to content

binder: fix TF_UPDATE_TXN supersede cleanup bugs

Tomer Pomeranc lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2binder: fix leaked fd fixups on TF_UPDATE_TXN supersededrivers/android/binder.c+1 -01 reply
2/2binder: fix is_failure flag for superseded transaction cleanupdrivers/android/binder.c+1 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchCarlos Llamas
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] binder: fix TF_UPDATE_TXN supersede cleanup bugs

Two bugs in the t_outdated cleanup path of binder_proc_transaction(), both introduced by commit 9864bb480133 ("binder: add TF_UPDATE_TXN to replace outdated txn"):

1. kfree(t_outdated) is called without binder_free_txn_fixups(), permanently leaking binder_txn_fd_fixup entries and their fget()'d struct file references. The refcount never reaches zero; the leak survives process exit and accumulates until file-max exhaustion.

2. binder_release_entire_buffer() is called with is_failure=false for a transaction that was never delivered. Since binder_apply_fd_fixups() was never called, the BINDER_TYPE_FDA handler reads stale buffer data as fd numbers and closes unrelated fds via binder_deferred_fd_close().

Confirmed on mainline Linux (6.8.0-124-generic, binder_linux module) and Android (Pixel 8, kernel 6.1.124, /dev/hwbinder).

Tomer Pomeranc (2):
binder: fix leaked fd fixups on TF_UPDATE_TXN supersede
binder: fix is_failure flag for superseded transaction cleanup

 drivers/android/binder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.34.1