Skip to content

staging: media: atomisp: cleanup pci/hmm/ code

Nikolay Kulikov linux-media linux-staging lkml 4 versions – In review

Get series with b4
b4 am [email protected] change-id 20260813-atomisp_remove_hmm-407662efafaa

Versions newest first · linked by author and title

  1. v4 Latest5 patches 1 replyIn review
  2. v35 patches 3 repliesSuperseded
  3. v24 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches3 repliesSuperseded

Changes in v4 from the cover letter

- In commit 1, include the removal of the static 'hmm_bo_vm_ops' structure and the hmm_bo_vm_open() and hmm_bo_vm_close() functions (whose addresses are stored in that structure), as they have also become unused and are triggering compiler warinigs (I removed Andy Shevchenko's Rb tag because of this change).
- Add the Rb tag (commit 3).
- Add the base commit hash.
- Add links to v1/v2/v3.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5staging: media: atomisp: remove unused functions from pci/hmm/drivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/pci/hmm/hmm.c +1 more+0 -2150 replies
2/5staging: media: atomisp: inline macros for checking the bo/bodev pointerdrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/include/hmm/hmm_common.h drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+76 -400 replies
3/5staging: media: atomisp: inline the check_bo_status_*() macrosdrivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/include/hmm/hmm_common.h drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+20 -400 replies
4/5staging: media: atomisp: inline the var_equal_return*() macrosdrivers/staging/media/atomisp/include/hmm/hmm_common.h drivers/staging/media/atomisp/pci/hmm/hmm_bo.c+4 -220 replies
5/5staging: media: atomisp: remove hmm/hmm_common.h filedrivers/staging/media/atomisp/include/hmm/hmm.h drivers/staging/media/atomisp/include/hmm/hmm_bo.h drivers/staging/media/atomisp/include/hmm/hmm_common.h +1 more+0 -190 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy Shevchenko
SeriesR-b
1/5
2/5
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] staging: media: atomisp: cleanup pci/hmm/ code

This series removes unused functions and replaces obscure variable-checking macros with clear conditional statements.

Changes in v4:
- In commit 1, include the removal of the static 'hmm_bo_vm_ops' structure and the hmm_bo_vm_open() and hmm_bo_vm_close() functions (whose addresses are stored in that structure), as they have also become unused and are triggering compiler warinigs (I removed Andy Shevchenko's Rb tag because of this change).
- Add the Rb tag (commit 3).
- Add the base commit hash.
- Add links to v1/v2/v3.
Changes in v3:
- Split the last patch into two (inlining macros and removing the file).
- Replace variable initialization with assignment, followed immediately by a check.
Changes in v2:
- Squashed the function removals in pci/hmm/hmm.c and pci/hmm/hmm_bo.c into a single commit.
- Add commits to cleanup macros from include/hmm/hmm_common.h, as suggested by Andy Shevchenko.

v3: https://lore.kernel.org/linux-staging/[email protected]/
v2: https://lore.kernel.org/linux-staging/[email protected]/
v1: https://lore.kernel.org/linux-staging/[email protected]/

---
Nikolay Kulikov (5):
staging: media: atomisp: remove unused functions from pci/hmm/
staging: media: atomisp: inline macros for checking the bo/bodev pointer
staging: media: atomisp: inline the check_bo_status_*() macros
staging: media: atomisp: inline the var_equal_return*() macros
staging: media: atomisp: remove hmm/hmm_common.h file

 drivers/staging/media/atomisp/include/hmm/hmm.h    |  17 --
 drivers/staging/media/atomisp/include/hmm/hmm_bo.h |  46 ----
 .../staging/media/atomisp/include/hmm/hmm_common.h |  60 -----
 drivers/staging/media/atomisp/pci/hmm/hmm.c        |  41 ----
 drivers/staging/media/atomisp/pci/hmm/hmm_bo.c     | 272 ++++++++-------------
 5 files changed, 100 insertions(+), 336 deletions(-)

---
base-commit: cb08dcd0a896c3ac8073a57296f2377b106c35b4
change-id: 20260813-atomisp_remove_hmm-407662efafaa

Best regards,

Signature · 1 line
Nikolay Kulikov <[email protected]>