Skip to content

hw/usb/hcd-ehci: Fix Coverity CID 1685236 and check DMA errors

Jamin Lin qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v11 patch 5 repliesSuperseded

Changes in v3 from the cover letter

1. Make get_dwords() return bool

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/usb/hcd-ehci: Check for DMA errors in get_dwords()/put_dwords()hw/usb/hcd-ehci.c+16 -220 replies
2/3hw/usb/hcd-ehci: Make get_dwords() return boolhw/usb/hcd-ehci.c+22 -221 reply
3/3hw/usb/hcd-ehci: Handle get_dwords() failures in async writebackhw/usb/hcd-ehci.c+5 -50 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] hw/usb/hcd-ehci: Fix Coverity CID 1685236 and check DMA errors

v1:
1. Fix Fix Coverity CID 1685236

v2:
1. Drops the dead NULL test and checks the actual accesses instead, and makes put_dwords() return void since no caller can act on a failed writeback.

v3:
1. Make get_dwords() return bool

Jamin Lin (3):
hw/usb/hcd-ehci: Check for DMA errors in get_dwords()/put_dwords() hw/usb/hcd-ehci: Make get_dwords() return bool hw/usb/hcd-ehci: Handle get_dwords() failures in async writeback

 hw/usb/hcd-ehci.c | 90 ++++++++++++++++++++++-------------------------
 1 file changed, 42 insertions(+), 48 deletions(-)
Signature · 1 line
2.53.0