Skip to content

smb/client: fix fallocate range operation issues

Huiwen He linux-cifs 4 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 1 replyApplied
  2. v37 patches 10 repliesApplied
  3. v26 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Add Reviewed-by: Namjae Jeon <[email protected]> to all patches.
- The contents of patches 1, 2, and 5-7 are unchanged.
- Patch 3: update commit message to document the server deallocatio granularity limitation.
- Patch 4: relax the 4 KiB restriction to retain support for smaller insert ranges and update commit message.

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/7smb/client: validate new EOF for insert rangefs/smb/client/smb2ops.c+10 -20 replies
2/7smb/client: validate new EOF for zero rangefs/smb/client/smb2ops.c+8 -10 replies
3/7smb/client: mark file sparse before emulating insert rangefs/smb/client/smb2ops.c+5 -00 replies
4/7smb/client: fix data corruption in emulated insert rangefs/smb/client/smb2ops.c+106 -260 replies
5/7smb/client: fix integer truncation in collapse rangefs/smb/client/smb2ops.c+2 -20 replies
6/7smb/client: fix stale page cache in insert/collapse rangefs/smb/client/smb2ops.c+18 -50 replies
7/7smb/client: invalidate fscache for fallocate range operationsfs/smb/client/smb2ops.c+7 -00 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchChenXiaoSongNamjae Jeon
1/7R-b R-b
2/7R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] smb/client: fix fallocate range operation issues

From: Huiwen He <[email protected]>

This series fixes several issues in SMB3 fallocate range operations, including insert range, collapse range, zero range, and punch hole.

Changes in v4:
- Add Reviewed-by: Namjae Jeon <[email protected]> to all patches.
- The contents of patches 1, 2, and 5-7 are unchanged.
- Patch 3: update commit message to document the server deallocatio granularity limitation.
- Patch 4: relax the 4 KiB restriction to retain support for smaller insert ranges and update commit message.

Link to v3:
https://lore.kernel.org/linux-cifs/[email protected]

Thanks,
Huiwen

Huiwen He (7):
smb/client: validate new EOF for insert range smb/client: validate new EOF for zero range smb/client: mark file sparse before emulating insert range smb/client: fix data corruption in emulated insert range smb/client: fix integer truncation in collapse range smb/client: fix stale page cache in insert/collapse range smb/client: invalidate fscache for fallocate range operations

 fs/smb/client/smb2ops.c | 188 ++++++++++++++++++++++++++++++++--------
 1 file changed, 154 insertions(+), 34 deletions(-)
Signature · 1 line
2.43.0