Skip to content

KVM: s390: Improve floating IRQ injection behavior

Janosch Frank kvm linux-s390 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 0 repliesNew
  2. v43 patches 6 repliesSuperseded
  3. v33 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch6 repliesSuperseded
v11 patch2 repliesSuperseded

Changes in v5 from the cover letter

- Rebased on rc5
- Adjusted commit messages for first two patches (Christian)
- Moved opportunistic delivery into wait state handling (Christian)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3KVM: s390: Improve floating IRQ injection behaviorarch/s390/kvm/s390/interrupt.c+66 -200 replies
2/3KVM: s390: Kick PV cpus at the right time for service irqsarch/s390/kvm/s390/intercept.c arch/s390/kvm/s390/interrupt.c arch/s390/kvm/s390/s390.h+52 -80 replies
3/3KVM: s390: Add opportunistic floating IRQ deliveryarch/s390/include/asm/kvm_host_s390.h arch/s390/kvm/s390/interrupt.c arch/s390/kvm/s390/s390.c+36 -00 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchChristian Borntraeger
1/3A-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/3] KVM: s390: Improve floating IRQ injection behavior

Multiple fixes for the floating IRQ handling triggered by the firq kvm-unit-test sometimes failing for pv vms.

Only waking up cpus which are enabled, re-kicking after the instruction notification for pv cpus and a general redistribution of IRQs on entry (pending guidance from performance measurements).

The floating part of floating IRQs can make it difficult to make absolutely sure that an IRQ is actually delivered, especially if the OS doesn't regularly have the masks open. We might miss mask enablements if the intervention bits don't get set properly and the kicks might end up nowhere.

v5:
- Rebased on rc5
- Adjusted commit messages for first two patches (Christian)
- Moved opportunistic delivery into wait state handling (Christian)
v4:
- Replaced pv check with mask check which does not need locks
- Fixed bitnum to bitmask translations that Sashiko rightfully complained about
v3:
- Separated code into two patches
- Added a patch that fixes service injections for PV vms
- Added IRQ filtering and kick all if no cpu is enabled
- Fixed the IO pend type translation
v2:
- Rebase onto master
- Added IRQ type check before delivering

Janosch Frank (3):
KVM: s390: Improve floating IRQ injection behavior
KVM: s390: Kick PV cpus at the right time for service irqs
KVM: s390: Add opportunistic floating IRQ injection

 arch/s390/include/asm/kvm_host_s390.h |   1 +
 arch/s390/kvm/s390/intercept.c        |   9 ++
 arch/s390/kvm/s390/interrupt.c        | 156 ++++++++++++++++++++++----
 arch/s390/kvm/s390/s390.c             |   1 +
 arch/s390/kvm/s390/s390.h             |   1 +
 5 files changed, 147 insertions(+), 21 deletions(-)
Signature · 1 line
2.53.0