Skip to content

tracing: Fixes for v7.2

Steven Rostedt lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracing: Fix NULL pointer dereference in module event cache removalkernel/trace/trace_events.c+1 -10 replies
2/2tracing: Fix race between update_event_fields and, event_define_fieldskernel/trace/trace_events.c+2 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [for-linus][PATCH 0/2] tracing: Fixes for v7.2

tracing fixes for v7.2:

- Fix NULL pointer dereference when matching unloaded module wildcard event

The set_event can take events for modules that have not been loaded yet. This is done by writing '<event>:mod:<module>'.

If '<event>' is not added, then it means to add all events in <module>. This wildcard is represented by a NULL pointer. If one were to try to remove the same module item with a named event it would cause a NULL pointer dereference when comparing the NULL with the name in strcmp().

echo ':mod:kvm' > /sys/kernel/tracing/set_event echo '!kvm_ack_irq:mod:kvm' >> /sys/kernel/tracing/set_event

The above will do a strcmp("kvm_ack_irq", NULL) and crash the kernel.

Test for NULL (wildcard) before doing the strcmp().

- Fix event data field race in loading two modules at the same time

When a module loads, its trace events get registered. The fields of the events are also dynamically created and added to the events fields list. It also will call a function that will look at all the events for updates that need to be done. If two modules load at the same time, the one that scans all events and their fields may read the one being added as the scan doesn't take the event_mutex. This may cause a data race.

Have the scan take the event_mutex to prevent the race.

git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/fixes

Head SHA1: c3730b8373bb5059d735509b9e6a00d7eb337d7c

Hui Su (1):
tracing: Fix NULL pointer dereference in module event cache removal

Michael Wu (1):
tracing: Fix race between update_event_fields and, event_define_fields

----

 kernel/trace/trace_events.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)