Skip to content

drm/amdgpu: Remove is_idle method

[email protected] amd-gfx dri-devel lkml sashiko-reviews 1 version Applied

Status from this message: Applied. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4drm/amdgpu: Remove is_idle test casedrivers/gpu/drm/amd/display/amdgpu_dm/tests/amdgpu_dm_test.c+0 -100 replies
2/4drm/amdgpu: Remove is_idle (trivial cases)drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c +54 more+0 -2130 replies
3/4drm/amdgpu: Remove is_idle (non trivial functions)drivers/gpu/drm/amd/amdgpu/cik_ih.c drivers/gpu/drm/amd/amdgpu/cz_ih.c drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +25 more+0 -4141 reply
4/4drm/amdgpu: Remove is_idledrivers/gpu/drm/amd/include/amd_shared.h+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] drm/amdgpu: Remove is_idle method

From: "Dr. David Alan Gilbert" <[email protected]>

The is_idle method in amd_ip_funcs is never called, however there are some functions assigned to it.

Remove the bindings to it, and if the functions aren't called anywhere else remove the function as well.

Remove the kunit test hook for it.

In many cases the wait_for_idle code either calls the function which was wired to is_idle or duplicates the code (or curiously kind of duplicates it with changes).

Based on drm-next-7.3 0d710af8e4abdd1fa500bddbab7c0ee47fc98143. Booted on my Ryzen with RX560.
(That is spewing some warnings of the form:

[    9.680879] [PLANE:44:plane-0] pixel format with alpha exposed but blend mode not setup
[    9.680881] WARNING: drivers/gpu/drm/drm_mode_config.c:872 at drm_mode_config_validate+0x3c2/0x4f0, CPU#4: (udev-worker)/538

but I don't *think* I've gone anywhere near anything to do with pixel formats etc)

Dr. David Alan Gilbert (4):
drm/amdgpu: Remove is_idle test case drm/amdgpu: Remove is_idle (trivial cases) drm/amdgpu: Remove is_idle (non trivial functions) drm/amdgpu: Remove is_idle

 drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c       |  6 -----
 drivers/gpu/drm/amd/amdgpu/amdgpu_isp.c       |  6 -----
 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c      |  6 -----
 drivers/gpu/drm/amd/amdgpu/cik.c              |  7 ------
 drivers/gpu/drm/amd/amdgpu/cik_ih.c           | 12 ----------
 drivers/gpu/drm/amd/amdgpu/cik_sdma.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/cz_ih.c            | 12 ----------
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        |  6 -----
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |  6 -----
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |  6 -----
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c        | 12 ----------
 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c        | 12 ----------
 drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c        | 12 ----------
 drivers/gpu/drm/amd/amdgpu/gfx_v12_1.c        |  1 -
 drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c         | 11 ---------
 drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c       |  1 -
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c        |  7 ------
 drivers/gpu/drm/amd/amdgpu/gmc_v11_0.c        |  7 ------
 drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c        |  7 ------
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         | 13 -----------
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         |  7 ------
 drivers/gpu/drm/amd/amdgpu/iceland_ih.c       | 12 ----------
 drivers/gpu/drm/amd/amdgpu/ih_v6_0.c          |  7 ------
 drivers/gpu/drm/amd/amdgpu/ih_v6_1.c          |  7 ------
 drivers/gpu/drm/amd/amdgpu/ih_v7_0.c          |  7 ------
 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c        |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c        |  2 --
 drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c        |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c        |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c      |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c      |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c      |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c      |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_2.c      |  1 -
 drivers/gpu/drm/amd/amdgpu/jpeg_v5_3_0.c      |  1 -
 drivers/gpu/drm/amd/amdgpu/navi10_ih.c        |  7 ------
 drivers/gpu/drm/amd/amdgpu/nv.c               |  6 -----
 drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c        | 13 -----------
 drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c        | 13 -----------
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c        | 16 -------------
 drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c      | 16 -------------
 drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c        | 16 -------------
 drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c        | 16 -------------
 drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c        | 16 -------------
 drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c        | 16 -------------
 drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c        | 16 -------------
 drivers/gpu/drm/amd/amdgpu/si.c               |  6 -----
 drivers/gpu/drm/amd/amdgpu/si_dma.c           |  1 -
 drivers/gpu/drm/amd/amdgpu/si_ih.c            |  1 -
 drivers/gpu/drm/amd/amdgpu/soc15.c            |  6 -----
 drivers/gpu/drm/amd/amdgpu/soc21.c            |  6 -----
 drivers/gpu/drm/amd/amdgpu/soc24.c            |  6 -----
 drivers/gpu/drm/amd/amdgpu/soc_v1_0.c         |  6 -----
 drivers/gpu/drm/amd/amdgpu/tonga_ih.c         | 12 ----------
 drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c         |  8 -------
 drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c         |  8 -------
 drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c         |  8 -------
 drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/vce_v1_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/vce_v2_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/vce_v3_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c         |  1 -
 drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c         |  2 --
 drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c         | 16 -------------
 drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c         | 23 -------------------
 drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c       | 21 -----------------
 drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c       | 23 -------------------
 drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c       | 23 -------------------
 drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c       | 19 ---------------
 drivers/gpu/drm/amd/amdgpu/vcn_v5_0_2.c       | 19 ---------------
 drivers/gpu/drm/amd/amdgpu/vega10_ih.c        |  7 ------
 drivers/gpu/drm/amd/amdgpu/vega20_ih.c        |  7 ------
 drivers/gpu/drm/amd/amdgpu/vi.c               |  6 -----
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  8 -------
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |  1 -
 .../display/amdgpu_dm/tests/amdgpu_dm_test.c  | 10 --------
 drivers/gpu/drm/amd/include/amd_shared.h      |  2 --
 drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c    |  6 -----
 drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c    |  7 ------
 .../gpu/drm/amd/pm/powerplay/amd_powerplay.c  |  6 -----
 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c     |  1 -
 87 files changed, 639 deletions(-)
Signature · 1 line
2.55.0