accel/rocket: Fix allocation handling and scheduler array leak
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest2 patches 3 repliesApplied
- v52 patches 6 repliesSuperseded
- v42 patches 5 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 posting 2/2 | 1 patch | 0 replies | Superseded | |
| v3 posting 1/2 | 1 patch | 1 reply | Superseded | |
| v2 | 1 patch | 7 replies | Superseded | |
| v1 | 1 patch | 0 replies | Superseded |
Changes in v6 from the cover letter
- Rebase on top of drm-misc-next (base commit 5052ea2e6bfc43c64b851c596d3675d17e05e631)
- Addressed review feedback from previous iterations.
- Added Fixes and Tested-by tags where applicable.
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | accel/rocket: Check allocations before usedrivers/ | +6 | 1 reply | |
| 2/2 | drm/rocket: Keep scheduler allocation in rocket_file_privdrivers/ drivers/ | +4 | 1 reply |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by.
| Patch | Igor Paunovic | Sidong Yang |
|---|---|---|
| 1/2 | T-b T-b | T-b |
| 2/2 | T-b T-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/2] accel/rocket: Fix allocation handling and scheduler array leak
This small series addresses allocation and memory management issues in the accel/rocket driver:
1. Patch 1 ensures proper allocation checks before using pointers in rocket_job_open()
2. Patch 2 fixes an unreachable memory leak of the scheduler array when running on single-core setups (e.g., num_cores == 1), where drm_sched_entity_init() drops the array pointer.
Link to v5: https://lore.kernel.org/all/[email protected]/
Changes in v6:
- Rebase on top of drm-misc-next (base commit 5052ea2e6bfc43c64b851c596d3675d17e05e631)
- Addressed review feedback from previous iterations.
- Added Fixes and Tested-by tags where applicable.
Triet Hoang (2):
drm/rocket: Check allocations before use drm/rocket: Keep scheduler allocation in rocket_file_priv
drivers/accel/rocket/rocket_drv.h | 1 + drivers/accel/rocket/rocket_job.c | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-)
Signature · 1 line
2.53.0