Skip to content

RFC md/raid1: improve choose_best_rdev read balance

Chen Cheng linux-raid lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5md/raid1: balance reads across non-rotational disksdrivers/md/raid1.c drivers/md/raid1.h+22 -40 replies
2/5md/raid1: do not move nonrot reads onto a rot diskdrivers/md/raid1.c+33 -90 replies
3/5md/raid1: do not send random reads to a rot diskdrivers/md/raid1.c+5 -20 replies
4/5md/raid1: use rot policy when no nonrot disk is readabledrivers/md/raid1.c+19 -10 replies
5/5md/raid1: clarify choose_best_rdev commentsdrivers/md/raid1.c+35 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/5] md/raid1: improve choose_best_rdev read balance

From: Chen Cheng <[email protected]>

Prefer a nonrot disk when one can take the read. When pending is the same, use a real round-robin among the disks we may pick.

fio libaio direct=1, NVMe none, SATA mq-deadline (stock -> this):

- 2x GM9000: 1M QD16 j1 7.031 -> 13.886 GB/s, 50/50; 4k QD1 50/50
- 2x/3x HDWG740: 0.294 -> 0.514 / 0.630 GB/s
- GM9000+HDD seq: 2.468 or 0.280 -> 7.112 GB/s, 100/0 NVMe
- Fanxiang+HDD seq, HDD first: 0.278 -> 0.562 GB/s
- GM9000+HDD 4k QD8/16: clat -47% / -45%

Chen Cheng (5):
md/raid1: balance reads across non-rotational disks md/raid1: do not move nonrot reads onto a rot disk md/raid1: do not send random reads to a rot disk md/raid1: use rot policy when no nonrot disk is readable md/raid1: clarify choose_best_rdev comments

 drivers/md/raid1.c | 122 ++++++++++++++++++++++++++++++++++++++-------
 drivers/md/raid1.h |   1 +
 2 files changed, 104 insertions(+), 19 deletions(-)
Signature · 1 line
2.55.0