Skip to content

scsi: ufs: ufs-pci: Intel UFS 4.0 HS-Gear5 and MCQ support

sangram kumar yerra linux-scsi lkml 1 version Applied

Status from this message: Applied to 7.3/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2scsi: ufs: ufs-pci: Add support for Intel UFS 4.0 HS-Gear5drivers/ufs/host/ufshcd-pci.c+20 -00 replies
2/2scsi: ufs: ufs-pci: Add MCQ support for Intel UFS 4.0 controllersdrivers/ufs/host/ufshcd-pci.c+39 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAdrian HunterBart Van Assche
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] scsi: ufs: ufs-pci: Intel UFS 4.0 HS-Gear5 and MCQ support

096cd6b7adf2 ("scsi: ufs: ufs-pci: Add support for Intel Nova Lake") added the PCI ID for Intel's UFS 4.0 controller (8086:D335), reusing the existing Meteor Lake variant operations table. That table is missing two things this controller needs to work correctly at UFS 4.0
capability: a PA_INITIAL_ADAPT sequence for reliable HS-Gear5 link training, and the MCQ resource/runtime-config hooks required for ufshcd_alloc_mcq() to succeed. Without either, the controller still works, but silently falls back to Gear5 link instability or legacy single-doorbell mode respectively.

Patch 1 adds a pwr_change_notify hook that configures PA_INITIAL_ADAPT (resetting to the default PA_NO_ADAPT otherwise) before Gear5 power mode changes.

Patch 2 adds the mcq_config_resource and op_runtime_config hooks, with the OPR register offsets and stride this controller uses.

Both were validated on real NVL silicon: a 10-cycle reboot trial (5 minutes monitored each) with this exact configuration showed zero UIC-layer errors throughout, and MCQ hardware queues were confirmed carrying real doorbell traffic at the documented addresses.

sangram kumar yerra (2):
scsi: ufs: ufs-pci: Add support for Intel UFS 4.0 HS-Gear5
scsi: ufs: ufs-pci: Add MCQ support for Intel UFS 4.0 controllers

 drivers/ufs/host/ufshcd-pci.c | 59 +++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
Signature · 1 line
2.34.1