Skip to content

RFC the org.qemu.Display1.UIInfo interface design

Chengyang Zhu qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 RFC Latest1 patch 2 repliesIn review
  2. v3 RFC1 patch 5 repliesSuperseded
  3. v2 RFC1 patch 1 replySuperseded

Changes in v4 from the cover letter

* switched back to the dictionary approach.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1ui/dbus: add org.qemu.Display1.UIInfo interfaceui/dbus-console.c ui/dbus-display1.xml+156 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH RFC v4 0/1] the org.qemu.Display1.UIInfo interface design

Currently, the SetUIInfo method cannot set a refresh rate. Simply adding a refresh_rate argument would break the method signature.

This patch adds the UIInfo interface containing
* property Supported indicating whether console UI info is supported.
* the method Apply taking a dictionary as input.
* the method Get returning the current UI info as a dictionary.

Changes since v3:
* switched back to the dictionary approach.

This patch needs further discussion on:
* Updated/Changed signal as mentioned before in the v3 email thread.
* necessary test suite to prevent dictionary schema deviating from QemuUIInfo.

Test results:
* qemu:qtest-x86_64/dbus-display-test passed
* qemu:qtest-x86_64/dbus-vmstate-test passed
* qemu:qtest-x86_64/dbus-vnc-test SKIP
* manually created a virtual machine
and successfully set its refresh rate and resolution via Apply

Chengyang Zhu (1):
ui/dbus: add org.qemu.Display1.UIInfo interface

 ui/dbus-console.c    | 106 +++++++++++++++++++++++++++++++++++++++++++
 ui/dbus-display1.xml |  50 ++++++++++++++++++++
 2 files changed, 156 insertions(+)
Signature · 1 line
2.55.0