Skip to content

arm64: dts: amlogic: t7: fix UART clock and SD card recovery

Lucas Tanure linux-amlogic linux-arm-kernel linux-devicetree lkml 2 versions – Applied

Status from this message: Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v7.3/fixes)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesApplied
  2. v12 patches 8 repliesSuperseded

Changes in v2 from the cover letter

- Update UART clocks directly in the board DTS files instead of moving them to amlogic-t7.dtsi, as &xtal is defined at the board level.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2arm64: dts: amlogic: t7: use the real UART pclkarch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts+2 -21 reply
2/2arm64: dts: amlogic: t7: khadas-vim4: allow the SD card to be power cycledarch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts+0 -11 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchNeil Armstrong
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] arm64: dts: amlogic: t7: fix UART clock and SD card recovery

Two fixes found while booting mainline on a Khadas VIM4.

The first one wires uart_a to the real UART bus clock. It was pointed at the 24MHz crystal as a placeholder, because the T7 clock controller driver did not exist when these boards were added. That leaves the real clock without a user, so the kernel turns it off when it disables unused clocks at the end of boot, and the board hangs with the console gone.

The second one drops regulator-always-on from the SD card supply. A card that refuses the 1.8V UHS switch can only be recovered by removing its power, which that property prevents, so the card never initialises and the MMC core retries forever.

Both were tested on a Khadas VIM4 booting v7.2 from the SD card.

Changes in v2:
- Update UART clocks directly in the board DTS files instead of moving them to amlogic-t7.dtsi, as &xtal is defined at the board level.

Lucas Tanure (2):
arm64: dts: amlogic: t7: use the real UART pclk
arm64: dts: amlogic: t7: khadas-vim4: allow the SD card to be power
cycled

 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts       | 2 +-
 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-khadas-vim4.dts | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
Signature · 1 line
2.55.0